@ExplicitParameterInjection is now by default inherited for nested classes #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkouba
reviewed
Jan 19, 2024
junit5/src/main/java/org/jboss/weld/junit5/ExplicitParamInjection.java
Outdated
Show resolved
Hide resolved
mkouba
reviewed
Jan 19, 2024
...java/org/jboss/weld/junit5/explicitInjection/ExplicitParameterInjectionNestedClass2Test.java
Outdated
Show resolved
Hide resolved
|
Edited README, fixed copy-paste errors and tests and added a test for method-level declaration of this annotation which can now technically say |
mkouba
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #164
@ExplicitParameterInjectionnow has a configurablebooleanvalue indicating whether Weld should apply this behavior.Nested classes are automatically inspecting their enclosing classes for this annotation and it's value unless they declare it themselves.