Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Add simple Kotlin example #36

Merged
merged 1 commit into from
Mar 6, 2018
Merged

Add simple Kotlin example #36

merged 1 commit into from
Mar 6, 2018

Conversation

mkouba
Copy link
Member

@mkouba mkouba commented Mar 5, 2018

No description provided.

@mkouba mkouba requested a review from manovotn March 5, 2018 13:48
pom.xml Outdated
@@ -51,7 +51,7 @@
<maven.compiler.target>1.8</maven.compiler.target>
<!-- Versions -->
<version.cdi2>2.0</version.cdi2>
<version.weld3>3.0.2.Final</version.weld3>
<version.weld3>3.0.4-SNAPSHOT</version.weld3>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why snapshot dep?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, a mistake of course. I don't even remember I changed this ;-)

- also upgrade Weld to 3.0.3.Final
Copy link
Collaborator

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since my Kotlin knowledge is virtually nonexistent, I am afraid I cannot give you any reasonable review.
So I'll have to stick with the good old - LGTM! ;-)

@mkouba
Copy link
Member Author

mkouba commented Mar 5, 2018

You can follow the readme file and test the example manually ;-)

@mkouba mkouba merged commit 8bddf8c into weld:master Mar 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants