Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

with multiple repos lorax tries to install multiple versions of same package #368

Closed
dustymabe opened this issue May 31, 2018 · 16 comments
Closed

Comments

@dustymabe
Copy link
Contributor

For Atomic Host we are trying to build media as part of the updates composes. This includes an installer ISO. We hit this problem (example koji task) where lorax tries to install multiple versions of the same package. From the runroot.log:

dnf.exceptions.DepsolveError: 
 Problem 1: cannot install both iwl100-firmware-39.31.5.1-83.fc28.1.noarch and iwl100-firmware-39.31.5.1-85.fc28.1.noarch
  - conflicting requests

NOTE: ignore the fact that the koji task didn't fail, that was a pungi bug

I think this is a problem @bcl already knows about. From this comment He stated: "The NEVRA change was supposed to allow pinning of versions, but it has a problem when an updates repo is included."

@bcl
Copy link
Contributor

bcl commented May 31, 2018

This is a DNF bug that has supposedly been fixed upstream. https://bugzilla.redhat.com/show_bug.cgi?id=1548586#c3

@dustymabe
Copy link
Contributor Author

thanks for the info. I pinged them in the BZ to see if we can get that fixed in f28 to see if it resolves this issue.

@dustymabe
Copy link
Contributor Author

should this issue be closed ?

@bcl
Copy link
Contributor

bcl commented Aug 29, 2018

should this issue be closed ?

Not yet. AFAIK this is still happening on F28.

@dustymabe
Copy link
Contributor Author

dustymabe commented Oct 24, 2018

and I believe it is still an issue in f29

dnf.exceptions.DepsolveError: 
 Problem 1: cannot install both iwl100-firmware-39.31.5.1-88.fc29.noarch and iwl100-firmware-39.31.5.1-87.fc29.noarch
  - conflicting requests

@bcl
Copy link
Contributor

bcl commented Oct 24, 2018

I'm not seeing this with lorax-29.19, dnf-4.0.4-1, libdnf-0.22.0-6 using f29 repo, f29 updates (empty), and f29 updates-testing.

@dustymabe
Copy link
Contributor Author

@sinnykumari ran a test and this is the failure she saw: loraxrun.txt

I bet she wasn't using the dnf from updates-testing though. @sinnykumari can you update to the versions of rpms mentioned above and see if you have that problem?

@sinnykumari
Copy link

I was running lorax earlier on a F28 local machine to build FAH ISO for fedora-29-updates-testing by providing multiple repos. Reason of using F28 host is that our Fedora Koji builders are currently on Fedora 28.

FAH ISO creation on F29 host using lorax works fine. This works with lorax-29.19, dnf-3.5.1-1.fc29.noarch, libdnf-0.19.1-3.fc29.x86_64 and also with dnf-4.0.4-1.fc29.noarch, libdnf-0.22.0-6.fc29.x86_64.

Unfortunately Fedora 28 has dnf-2.7.5-12 latest available and as per dnf bz backporting fixes to 2.7 is not yet planned.

@dustymabe
Copy link
Contributor Author

so I think the runroot task installs dnf from the f29 repos inside the runroot and then executes lorax so we should be ok? See the runroot log for Fedora-29-updates-testing-20181024.0.

If I'm right we should be fine here and should be able to close this bug.

@sinnykumari
Copy link

Yes, installation occurs from F29 repos. But the lorax failure (lorax log ) is at earlier steps "Checking dependencies
" which I think uses host system dnf to resolve dependencies. After dependencies is fulfilled, Downloading F29 packages and other steps takes place.

@dustymabe
Copy link
Contributor Author

hmm. but lorax isn't even installed on the builder hosts.. it's only installed into the runroot I think. Check out the root.log from the koji task where the rpms get installed into the runroot:

lorax                               x86_64 29.16-1.fc29
dnf                                 noarch 4.0.4-1.fc29

@sinnykumari
Copy link

Ah, runroot task runs under mock and my assumption was that lorax runs directly on builders. I was looking at pungi logs from which I didn't realized that it is using mock. We should be good then, sorry about confusion :)

@bcl
Copy link
Contributor

bcl commented Oct 25, 2018

Ok, good. I'm going to add a bunch of lorax tests, starting with the f28-branch, to catch this and other things. Then I'll kludge in a fix for it since it doesn't look like dnf is going to have time.

@dustymabe
Copy link
Contributor Author

Ok, good. I'm going to add a bunch of lorax tests, starting with the f28-branch, to catch this and other things. Then I'll kludge in a fix for it since it doesn't look like dnf is going to have time.

we technically don't need this in f28 any longer so if you don't need it I wouldn't waste your time.

@bcl
Copy link
Contributor

bcl commented Oct 25, 2018

we technically don't need this in f28 any longer so if you don't need it I wouldn't waste your time.

Thanks, I want to make sure f28 will work with updates repo enabled, and make sure it continues to work :)

@bcl
Copy link
Contributor

bcl commented Oct 26, 2018

PR #514 fixes this.

@bcl bcl closed this as completed Oct 26, 2018
henrysher pushed a commit to henrysher/fedora-infra-ansible that referenced this issue Oct 30, 2018
* Latest dnf available in F29 solves the lorax issue while
  using multiple repos - weldr/lorax#368
  Including latest updates and updates-testing repo will help us to
  test latest fixes done in packages which composes AH ISO.
* With F29 RC 1.2 declared Gold, update Atomic Host repo for OSTree
  and artifacts creation from /compose/branched/ to compose/29/
* With F29 RC 1.2 declared Gold, update Silverblue repo for OSTree
  creation from /compose/branched/ to compose/29/
FrostyX pushed a commit to FrostyX/fedora-infra-ansible that referenced this issue Dec 4, 2018
* Latest dnf available in F29 solves the lorax issue while
  using multiple repos - weldr/lorax#368
  Including latest updates and updates-testing repo will help us to
  test latest fixes done in packages which composes AH ISO.
* With F29 RC 1.2 declared Gold, update Atomic Host repo for OSTree
  and artifacts creation from /compose/branched/ to compose/29/
* With F29 RC 1.2 declared Gold, update Silverblue repo for OSTree
  creation from /compose/branched/ to compose/29/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants