-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
with multiple repos lorax tries to install multiple versions of same package #368
Comments
This is a DNF bug that has supposedly been fixed upstream. https://bugzilla.redhat.com/show_bug.cgi?id=1548586#c3 |
thanks for the info. I pinged them in the BZ to see if we can get that fixed in f28 to see if it resolves this issue. |
should this issue be closed ? |
Not yet. AFAIK this is still happening on F28. |
and I believe it is still an issue in f29
|
I'm not seeing this with lorax-29.19, dnf-4.0.4-1, libdnf-0.22.0-6 using f29 repo, f29 updates (empty), and f29 updates-testing. |
@sinnykumari ran a test and this is the failure she saw: loraxrun.txt I bet she wasn't using the dnf from updates-testing though. @sinnykumari can you update to the versions of rpms mentioned above and see if you have that problem? |
I was running lorax earlier on a F28 local machine to build FAH ISO for fedora-29-updates-testing by providing multiple repos. Reason of using F28 host is that our Fedora Koji builders are currently on Fedora 28. FAH ISO creation on F29 host using lorax works fine. This works with lorax-29.19, dnf-3.5.1-1.fc29.noarch, libdnf-0.19.1-3.fc29.x86_64 and also with dnf-4.0.4-1.fc29.noarch, libdnf-0.22.0-6.fc29.x86_64. Unfortunately Fedora 28 has dnf-2.7.5-12 latest available and as per dnf bz backporting fixes to 2.7 is not yet planned. |
so I think the runroot task installs dnf from the f29 repos inside the runroot and then executes lorax so we should be ok? See the runroot log for If I'm right we should be fine here and should be able to close this bug. |
Yes, installation occurs from F29 repos. But the lorax failure (lorax log ) is at earlier steps "Checking dependencies |
hmm. but lorax isn't even installed on the builder hosts.. it's only installed into the runroot I think. Check out the root.log from the koji task where the rpms get installed into the runroot:
|
Ah, runroot task runs under mock and my assumption was that lorax runs directly on builders. I was looking at pungi logs from which I didn't realized that it is using mock. We should be good then, sorry about confusion :) |
Ok, good. I'm going to add a bunch of lorax tests, starting with the f28-branch, to catch this and other things. Then I'll kludge in a fix for it since it doesn't look like dnf is going to have time. |
we technically don't need this in f28 any longer so if you don't need it I wouldn't waste your time. |
Thanks, I want to make sure f28 will work with updates repo enabled, and make sure it continues to work :) |
PR #514 fixes this. |
* Latest dnf available in F29 solves the lorax issue while using multiple repos - weldr/lorax#368 Including latest updates and updates-testing repo will help us to test latest fixes done in packages which composes AH ISO. * With F29 RC 1.2 declared Gold, update Atomic Host repo for OSTree and artifacts creation from /compose/branched/ to compose/29/ * With F29 RC 1.2 declared Gold, update Silverblue repo for OSTree creation from /compose/branched/ to compose/29/
* Latest dnf available in F29 solves the lorax issue while using multiple repos - weldr/lorax#368 Including latest updates and updates-testing repo will help us to test latest fixes done in packages which composes AH ISO. * With F29 RC 1.2 declared Gold, update Atomic Host repo for OSTree and artifacts creation from /compose/branched/ to compose/29/ * With F29 RC 1.2 declared Gold, update Silverblue repo for OSTree creation from /compose/branched/ to compose/29/
For Atomic Host we are trying to build media as part of the updates composes. This includes an installer ISO. We hit this problem (example koji task) where lorax tries to install multiple versions of the same package. From the runroot.log:
NOTE: ignore the fact that the koji task didn't fail, that was a pungi bug
I think this is a problem @bcl already knows about. From this comment He stated: "The NEVRA change was supposed to allow pinning of versions, but it has a problem when an updates repo is included."
The text was updated successfully, but these errors were encountered: