dnf5: set releasever in the base object's vars #1379
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Fedora 40 now branched, openQA installer build tests started failing with an error: RuntimeError: cannot open file: (2) - No such file or directory [/etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-$releasever-x86_64] it seems like setting releasever via set_substitutions just does not fully work as expected, and libdnf goes looking for a file with a literal `$releasever` in it based on the gpgkey line in the repo file. Though it seems like the releasever substitution must work to *some* extent because we at least manage to resolve and download packages before the failure. This seems to fix it, anyhow, and is based on code from libdnf5 itself in dnf5/main.cpp RootCommand::set_argument_parser() . Signed-off-by: Adam Williamson <awilliam@redhat.com>
|
I really don't know all the details behind what's going on here, or if this is the correct long-term fix. But it at least fixes it for now and I need to get the openQA tests working again, so I'm going to do a downstream build with this patch, and I submitted this PR so we have everything nicely referenced. I kinda suspect this may ultimately be a libdnf bug? It seems like setting this via |
|
Oh, forgot to note - this happened only after Branching because Rawhide repo config files don't use |
Pull Request Test Coverage Report for Build 7898100212Details
💛 - Coveralls |
|
Full |
This was referenced Feb 14, 2024
|
Fixed in #1380 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Fedora 40 now branched, openQA installer build tests started failing with an error:
RuntimeError: cannot open file: (2) - No such file or directory [/etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-$releasever-x86_64]
it seems like setting releasever via set_substitutions just does not fully work as expected, and libdnf goes looking for a file with a literal
$releaseverin it based on the gpgkey line in the repo file. Though it seems like the releasever substitution must work to some extent because we at least manage to resolve and download packages before the failure.This seems to fix it, anyhow, and is based on code from libdnf5 itself in dnf5/main.cpp RootCommand::set_argument_parser() .