Fix depsolving empty recipes #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running tests somewhere else than Central Time, `test_api_time()`
fails like
AssertionError: '1985-10-27T02:00:00' != '1985-10-26T21:00:00'
`test_yaps_to_project_info()` fails in a similar way.
Pin the time zone to UTC for this test and adjust timestamps to UTC.
- Fix `projects_depsolve()` to not consider a successful empty response (rc == 0) as an error. - Fix recipe_from_dict() to default modules and packages to empty lists instead of `None`, to avoid a Python-ism in the API for consumers and stay compatible to the bdcs API. Fixes #290
|
Hmm, do the tests run in CI somewhere? Other PRs do seem to do that. |
This was referenced Dec 12, 2017
not for the lorax-composer branch ATM. It's on my todo but I'd like to get done with configuring CI for the other repos as well. |
|
Ah, ok. I ran all the tests locally, and aside from #292 (which is unaffected by this PR and unrelated) they all pass now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
projects_depsolve()to not consider a successful empty response(rc == 0) as an error.
instead of
None, to avoid a Python-ism in the API for consumers andstay compatible to the bdcs API.
Fixes #290
This PR also fixes two unrelated test failures and a tiny log error copy-pasta error, while I was at it.