Add support for bytestring 0.11 #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Until |
sjakobi
force-pushed
the
bytestring-0.11
branch
from
ad1bfda
to
03ec486
Compare
|
Ping @bgamari, @thoughtpolice! :) |
dcoutts
reviewed
Feb 23, 2021
There was a problem hiding this comment.
Thanks!
If you don't mind, I'll separate this out a bit:
- separating the bytestring version relaxation patch from the travis changes as a separate patch
- dropping the patch that drops support for older ghc versions (it's not terrible to drop support, but it doesn't need to be bundled in this PR)
sjakobi
force-pushed
the
bytestring-0.11
branch
from
03ec486
to
005fbe3
Compare
Since cborg uses the internal PS constructor which is a bundled pattern synonym in bytestring >= 0.11, we stick to bytestring < 0.11 for GHC < 8.0 where bundled pattern synonyms aren't supported.
sjakobi
force-pushed
the
bytestring-0.11
branch
from
005fbe3
to
87924d9
Compare
|
Thanks for the suggestion @dcoutts. I've much simplified the patch by disallowing |
dcoutts
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://hackage.haskell.org/package/bytestring-0.11.0.0/changelog
Since cborg uses the internal PS constructor which is a bundled pattern
synonym in bytestring >= 0.11, we stick to bytestring < 0.11 for
GHC < 8.0 where bundled pattern synonyms aren't supported.