Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new StaffWithRestricted patron type #403

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Add new StaffWithRestricted patron type #403

merged 1 commit into from
Jun 10, 2024

Conversation

kenoir
Copy link
Contributor

@kenoir kenoir commented Jun 6, 2024

What does this change?

In order to better restrict who has access to certain images, this change adds a new patron type for staff that should have access to restricted images (reducing this from all staff to only staff with this role).

This change will require an update to the IIIF API mappings here: https://github.com/wellcomecollection/iiif-builder/blob/main/src/AuthTest/AuthTest/Controllers/HomeController.cs#L38, requested in Slack. The new mapping should allow only StaffWithRestricted access to restricted images.

Related: wellcomecollection/iiif-builder#270

In addition this will require an update to the OpenAthens configuration that currently uses the Staff role from Auth0 to distinguish who should have access to certain journals. New configuration will need to include also the StaffWithRestricted type. See the #wc-open-athens Slack.

For #400

Part of: wellcomecollection/platform#5747

How to test

  • Run the tests, do they pass?
  • Deploy this change, ask a test user to login - is their patron type updated in Auth0?
  • When the IIIF API changes have occurred, can only the new staff type get access to restricted images?

How can we measure success?

Only staff users who need access to restricted images should have access to those images.

Have we considered potential risks?

We are changing authentication for some users, but this should reduce permissions for staff rather than increase it. We should see if we can test this change on stage before releasing.

@kenoir kenoir requested a review from a team as a code owner June 6, 2024 13:39
@kenoir kenoir merged commit ceb60c2 into main Jun 10, 2024
3 checks passed
@kenoir kenoir deleted the rk/add-patron-type branch June 10, 2024 08:20
@kenoir
Copy link
Contributor Author

kenoir commented Jun 10, 2024

Closes: #400

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants