Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude transitive dependency on pre 5.7 version of JNA #237

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

kenoir
Copy link
Contributor

@kenoir kenoir commented Jan 19, 2024

What does this change?

Follows #236, and required for the same reason. We are still pulling in an old version of the JNA library causing this issue (pre 5.7), see:

We exclude the JNA lib as a transitive dep, which avoids packaging it and blowing up downstream consumers.

https://github.com/elastic/apm-agent-java/blob/be8add66d074febe16748691725b6cfe69f238d0/docs/setup-attach-api.asciidoc

Using publishLocal to try this out locally before release and running a project that incorporates this dependency where we've seen this issue, the runtime error is fixed and we can see the dependency excluded.

Resolves this issue: wellcomecollection/catalogue-api#737 (comment)

See the dep being excluded (jna-platform is still there, but jna is excluded).
Screenshot 2024-01-19 at 16 02 41

How to test

  • Tests pass?
  • Consumers are free from error when trying to run projects that include this library on M1 macs.

How can we measure success?

Developers can run projects locally on their machines without issue.

Have we considered potential risks?

It's possible we hit one of the special conditions described in the caveats. We'll see this if consumers fail!

@kenoir kenoir changed the title Release bumping elastic apm libraries to use a version of jna after 5.7 Exclude transitive dependency on pre 5.7 version of JNA Jan 19, 2024
@kenoir kenoir requested a review from a team January 22, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants