Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deprecation warnings (>=Symfony 4.3) #32

Closed
PWalkow opened this issue Jan 30, 2020 · 3 comments
Closed

fix deprecation warnings (>=Symfony 4.3) #32

PWalkow opened this issue Jan 30, 2020 · 3 comments

Comments

@PWalkow
Copy link

PWalkow commented Jan 30, 2020

The "Symfony\Component\Config\Definition\Builder\TreeBuilder::root()" method called for the "welp_mailchimp" configuration is deprecated since Symfony 4.3, pass the root name to the constructor instead.

very similiar to #25

example of fix in doctrine-bundle

$treeBuilder = new TreeBuilder('doctrine');

if (method_exists($treeBuilder, 'getRootNode')) {
    $rootNode = $treeBuilder->getRootNode();
} else {
    // BC layer for symfony/config 4.1 and older
   $rootNode = $treeBuilder->root('doctrine');
}
@PWalkow PWalkow changed the title fix deprecation warnings (>=Symfony 4.4) fix deprecation warnings (>=Symfony 4.3) Jan 30, 2020
@Nightbr
Copy link
Member

Nightbr commented Jan 30, 2020

Hey, thanks for the report

Feel free to open a Pull Request for this 👌

@PWalkow
Copy link
Author

PWalkow commented Jan 31, 2020

@Nightbr , sure thing!

laurent-bientz added a commit to WandiParis/mailchimp-bundle that referenced this issue Aug 6, 2021
Nightbr added a commit that referenced this issue Aug 6, 2021
@Nightbr
Copy link
Member

Nightbr commented Aug 6, 2021

Fixed in 1.3.2

@Nightbr Nightbr closed this as completed Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants