-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug Report] Arabic tags are stick together #263
Comments
If adding a space is a suitable solution, then I will create a PR for it, or you can suggest another solution |
Thanks for reporting this bug! Is this still an issue if you set the language to Arabic after #262? Also: in both images (expected vs current behavior) I see good spacing between the tags. I'm not sure I understand the bug. From your description, I expected to see a bunch of grouped tags like "شرحشيما". |
Yes, I actually test it in it's branch, but didn't mention it because it's was not released yet
No, there is 3 tags which is "شرح", "شي and "ما", and it's should looks as separated tags of course, but now it's look like one word "شرحشيما" with spaces between the actual words, some like "شرحـ ـشيـ ـما" |
So there is space, but not enough of it? |
I'm not a frontend developer so I can't point for the issue exactly, but what I know there is space between tags, but there is no space between the words, so because that it's comes like one word. It doesn't really make sense, but yeah this is Arabic |
Don't worry, I'm just trying to understand the issue. So:
Am I understanding it right? |
No, the tags of the example above is [taxonomies]
tags = ["شرح", "شي", "ما"] |
If I add the spaces like this: <div class="bloglist-tags">
<a class="tag" href="http://127.0.0.1:1111/tags/shrh/"> شرح</a>
<a class="tag" href="http://127.0.0.1:1111/tags/shy/"> شي</a>
<a class="tag" href="http://127.0.0.1:1111/tags/m/"> ما</a>
</div> It looks like: If I don't change anything (current behaviour), the tags look like: To my non-Arabic-reading eyes, this looks like a minor difference? Is the top image the ideal, and the bottom the problem? |
I can reproduce the issue on Chromium. It looks fine on Firefox/Safari. Are you using a Chromium browser (Chrome, Brave, Vivaldi…)? |
Yes Brave |
Can you try this? .bloglist-tags {
margin-top: 0.1rem;
.tag {
display: inline-block;
margin-right: 0.7rem;
font-weight: 400;
font-size: 0.75rem;
text-transform: uppercase;
} Does this solve the issue? |
I'll soon in the morning, now it's 1:06 AM and I close the laptop :) |
Yes it's, I'll open a PR |
Bug Report
When I wrote a tags in Arabic, the tags are stick together without any space between them.
Environment
Zola version:
zola 0.18.0
tabi version or commit: 8b5a131
Expected Behavior
Something like (I dont know HTML/CSS that match, so this is my fix but I don't think is the good one) I adding space btw
Current Behavior
Clearly Describe the Bug
The tags are stick together without any space between them and comes like this
شرحشيما
instead ofشرح شي ما
Step to Reproduce
Write a tags in Arabic and see the result.
The text was updated successfully, but these errors were encountered: