-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ feat(i18n): add Right-to-left script support #262
Conversation
As I saw, after experimenting with writing an article in Arabic, this is the only change to support RTL |
Hi Awiteb! Thanks for this PR! I am curious: did you consider other options to implement this? To avoid adding an
What are your thoughts? |
I like this, so should I add it to the |
Even though it will only be used once (as far as I can foresee), I think using the macro is a good idea, yes. That way we can centralise the logic on one spot. |
As I found, there is only 12 RTL languages which is
I'll make the |
b9c051f
to
89b9fa4
Compare
Ok, I think this is better than macros |
89b9fa4
to
d921d3a
Compare
I've made that change + minor stuff (spacing; rename variable). Merging now. Many thanks for your contribution!!! |
Co-authored-by: welpo <welpo@users.noreply.github.com>
Add support for RTL languages, such as Arabic and Hebrew, by adding the
dir
attribute to thebody
tag if the language is RTL.What changes did you make?
I added the
extra.rtl
andextra.lang_rtl.<lang>
to the config, with this change, we can specify the languages that are RTL and thedir
attribute will be added to thebody
tag.