Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ refactor: improve stylised feed translations & consolidate XSL/CSS loading #98

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

welpo
Copy link
Owner

@welpo welpo commented Jul 31, 2023

This PR builds on the work of PR #96, further enhancing the internationalization handling and consolidating the XSL and CSS loading for the Atom feeds.

Key changes include:

  1. Unification of Translations into config.toml: All translations have been moved into config.toml and are loaded into a custom subspace within atom.xml. This change greatly simplifies the handling and extension of multilingual support in the feeds.

  2. Consolidation of XSL Logic: Instead of having separate XSL files for each language, this consolidates all XSL logic into a single file. This unified XSL file dynamically adapts the language, offering a more streamlined and maintainable approach.

  3. Universal CSS Loading: Fixes the loading of main.css, ensuring it properly loads regardless of the current language or domain setup. This guarantees a consistent styling across all language versions of the feeds.

This refactoring and consolidation not only simplify the codebase, making it more maintainable, but also enhance the feed's multi-language support. Future language additions should be much more straightforward, requiring only additions to the config.toml file, instead of creating extra xsl files.

♻️ refactor: consolidate XSL transformations into single file

🐛 fix: correct loading of main.css across languages/domains
@welpo welpo changed the title Refactor i18n Handling and Consolidate XSL/CSS Loading ♻️ refactor: improve stylised feed translations & consolidate XSL/CSS loading Jul 31, 2023
@welpo welpo merged commit 32b1177 into main Jul 31, 2023
1 check passed
@welpo welpo deleted the refactor/unify-atom-translations branch July 31, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant