Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multilingual issues in feeds and 'nav.html' #96

Merged
merged 4 commits into from
Jul 31, 2023

Conversation

Smtbook
Copy link
Contributor

@Smtbook Smtbook commented Jul 31, 2023

Feeds in other language seemed broken, and I changed 'nav.html' to fix issues when the length of language code is not 2.

This is my first PR, warn me if I did anything wrong.

@Smtbook Smtbook mentioned this pull request Jul 31, 2023
@Smtbook Smtbook marked this pull request as ready for review July 31, 2023 08:13
@welpo
Copy link
Owner

welpo commented Jul 31, 2023

Thanks for your contribution!

I will translate the text from the new feed_style files and ensure the default (en.xsl) is loaded if there's no language-specific file. This way we avoid errors in feeds for users who use a different language but haven't created the feed_style/{lang} file.

@welpo
Copy link
Owner

welpo commented Jul 31, 2023

All done! Merging :)

Thanks again.

EDIT: Accidentally closed it. Oops.

@welpo welpo closed this Jul 31, 2023
@welpo welpo reopened this Jul 31, 2023
@welpo welpo merged commit 2157a0b into welpo:main Jul 31, 2023
@welpo welpo added enhancement New feature or request and removed enhancement New feature or request labels Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants