Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fixed issue #188 #192

Merged
merged 6 commits into from
Oct 4, 2023
Merged

🐛 Fixed issue #188 #192

merged 6 commits into from
Oct 4, 2023

Conversation

Almost-Senseless-Coder
Copy link
Contributor

  • Removed unnecessary seeting of aria-label via JS,
  • Fixed theme_switcher.html template to correctly use i18n for the aria-label.

@welpo
Copy link
Owner

welpo commented Oct 4, 2023

Thanks, Tim! I've added a commit to further minify the file using terser -mc.

@welpo welpo merged commit 2eaee65 into welpo:main Oct 4, 2023
@welpo welpo added bug Something isn't working i18n Internationalisation labels Oct 4, 2023
@welpo welpo linked an issue Oct 4, 2023 that may be closed by this pull request
Incorrect i18n on theme switcher #188
Closed
Smtbook pushed a commit to Smtbook/zola-theme-tabi that referenced this pull request Feb 29, 2024
@Almost-Senseless-Coder @TimBoettcher
@welpo @Smtbook
🌐 fix(theme-switcher): properly translate aria-label (welpo#192)
3fdaab7 
Co-authored-by: Tim Böttcher <tim.boettcher2@rwth-aachen.de>
Co-authored-by: welpo <welpo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@welpo welpo Awaiting requested review from welpo welpo is a code owner

Assignees
No one assigned
Labels
bug Something isn't working i18n Internationalisation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect i18n on theme switcher
3 participants
@Almost-Senseless-Coder @welpo @TimBoettcher