Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat(shortcodes): add inline option to image shortcodes #315

Merged
merged 1 commit into from
May 18, 2024

Conversation

welpo
Copy link
Owner

@welpo welpo commented May 18, 2024

Summary

Adds an inline option to all image shortcodes (except the full_width one, for obvious reasons). When set to true, the image(s) will be displayed inline with the text. The images will be vertically aligned with the text.

Related issue

Idea from #314.

Accessibility

No changes; tested with VoiceOver.

Type of change

  • Bug fix (fixes an issue without altering functionality)
  • New feature (adds non-breaking functionality)
  • Breaking change (alters existing functionality)
  • UI/UX improvement (enhances user interface without altering functionality)
  • Refactor (improves code quality without altering functionality)
  • Documentation update
  • Other (please describe below)

Checklist

  • I have verified the accessibility of my changes
  • I have tested all possible scenarios for this change
  • I have updated theme.toml with a sane default for the feature
  • I have made corresponding changes to the documentation (shortcodes post).

@welpo welpo force-pushed the feat/support-inline-on-image-shortcodes branch from 9035ebb to 94618ae Compare May 18, 2024 12:52
@welpo welpo merged commit 27525fc into main May 18, 2024
2 of 3 checks passed
@welpo welpo deleted the feat/support-inline-on-image-shortcodes branch May 18, 2024 12:52
@welpo welpo mentioned this pull request May 18, 2024
@welpo welpo added the enhancement New feature or request label May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant