Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing quotes around some expressions #367

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

DataTriny
Copy link
Contributor

Summary

Adds quotes around expressions in places where they were missing.

Changes

Mostly fixed href attributes of links, errors which are ignored by web browsers. Also fixed alt and title attributes of links inside the social navigation block.

Accessibility

This was my initial motivation for doing this, as missing quotes around alt and title attributes on links inside the social navigation block prevents putting text with spaces.

Type of change

  • Bug fix (fixes an issue without altering functionality)
  • New feature (adds non-breaking functionality)
  • Breaking change (alters existing functionality)
  • UI/UX improvement (enhances user interface without altering functionality)
  • Refactor (improves code quality without altering functionality)
  • Documentation update
  • Other (please describe below)

Checklist

  • I have verified the accessibility of my changes
  • I have tested all possible scenarios for this change
  • I have updated theme.toml with a sane default for the feature
  • I have made corresponding changes to the documentation:
    • Updated config.toml comments
    • Updated theme.toml comments
    • Updated "Mastering tabi" post in English
    • (Optional) Updated "Mastering tabi" post in Spanish
    • (Optional) Updated "Mastering tabi" post in Catalan

@DataTriny DataTriny requested a review from welpo as a code owner August 23, 2024 17:26
Copy link

netlify bot commented Aug 23, 2024

Deploy Preview for tabi-demo ready!

Name Link
🔨 Latest commit b7f6019
🔍 Latest deploy log https://app.netlify.com/sites/tabi-demo/deploys/66c8c62c0ec015000872fd70
😎 Deploy Preview https://deploy-preview-367--tabi-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@welpo
Copy link
Owner

welpo commented Aug 23, 2024

Thank you, Arnold!

@welpo welpo merged commit ce3be5c into welpo:main Aug 23, 2024
6 of 7 checks passed
@DataTriny DataTriny deleted the missing-quotes branch August 23, 2024 19:49
@welpo welpo added the refactor Reestructure the code without changing behaviour label Aug 24, 2024
TheAwiteb pushed a commit to TheAwiteb/tabi that referenced this pull request Aug 26, 2024
TheAwiteb pushed a commit to TheAwiteb/tabi that referenced this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Reestructure the code without changing behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants