Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it necessary to make a View() generic for psyphr_study? #64

Open
iqis opened this issue Jul 29, 2019 · 3 comments
Open

Is it necessary to make a View() generic for psyphr_study? #64

iqis opened this issue Jul 29, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@iqis
Copy link
Contributor

iqis commented Jul 29, 2019

as psyphr_study contains a data column that is very big and complex, it makes calls to View() very slow.
Is it necessary to make a generic of View() that ignores the actual contents in data?

@iqis iqis self-assigned this Jul 29, 2019
@iqis iqis added enhancement New feature or request question Further information is requested labels Jul 29, 2019
@wendtke
Copy link
Owner

wendtke commented Jul 29, 2019

I think this would be useful, considering the end-user behaviors we might expect (e.g., click or write View() upon loading data). Newer useRs might be confused by the collapsed data column.

@iqis
Copy link
Contributor Author

iqis commented Jul 29, 2019

it seems that the generic approach would not work and otherwise achieving so would require digging very deep into rstudio's api, as the original utils::View() is brutally overridden by one from the namespace tools:rstudio.

I'll keep trying. However it may be a better idea to report this as a bug to RS at the end.

@wendtke
Copy link
Owner

wendtke commented Jul 29, 2019

I think that would be appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants