-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ping endpoint, closes #155 #158
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
from django.apps import AppConfig | ||
|
||
|
||
class HealthConfig(AppConfig): | ||
name = 'health' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
def check_database_connection(**kwargs): | ||
from django.db import connections | ||
from django.db.utils import OperationalError | ||
db_conn = connections['default'] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You are checking only default database connection. If you add N databases and if one of these databases goes down, your system return that's all is ok, and it's not true. |
||
if not db_conn: | ||
return False | ||
try: | ||
db_conn.cursor() | ||
return True | ||
except OperationalError as e: | ||
return False | ||
|
||
|
||
def check_accessible_api(request, **kwargs): | ||
import requests | ||
HTTP_HOST = request.META.get('HTTP_HOST') | ||
repositories_url = 'http://{}/api/repositories/'.format(HTTP_HOST) | ||
request = requests.get(repositories_url) | ||
try: | ||
request.raise_for_status() | ||
return True | ||
except requests.HTTPError as e: | ||
return False |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
# from django.test import TestCase |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
from collections import OrderedDict | ||
from functools import reduce | ||
|
||
from django.http import HttpResponse | ||
from rest_framework import status | ||
|
||
from .checks import check_database_connection | ||
from .checks import check_accessible_api | ||
|
||
CHECKS = [ | ||
check_database_connection, | ||
check_accessible_api, | ||
] | ||
|
||
|
||
def ping(request): | ||
checks_status = OrderedDict(map( | ||
lambda check: (check.__name__, check(request=request)), | ||
CHECKS)) | ||
healthy = reduce( | ||
lambda current, status: current and status, | ||
checks_status.values(), | ||
True) | ||
content = '{}\n{}'.format( | ||
'OK' if healthy else 'something wrong happened', | ||
'\n'.join(map( | ||
lambda x: '{}: {}'.format(*x), | ||
checks_status.items()))) | ||
status_code = status.HTTP_200_OK \ | ||
if healthy else status.HTTP_503_SERVICE_UNAVAILABLE | ||
return HttpResponse( | ||
content=content, | ||
content_type='text/plain', | ||
status=status_code) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can improve this code like that: