Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest code change causes rounds to not resolve #10

Open
BigBadBurrow opened this issue Jan 22, 2019 · 1 comment
Open

Latest code change causes rounds to not resolve #10

BigBadBurrow opened this issue Jan 22, 2019 · 1 comment

Comments

@BigBadBurrow
Copy link

BigBadBurrow commented Jan 22, 2019

In the latest code commit in env.step() you changed:

    else:
      self._resolve(players)

to this:

    if all([player.playedthisround for player in players]):
      self._resolve(players)

But rounds are getting stuck, constantly asking for the move from the same player. Maybe playedthisround isn't being set somewhere, or is being unset, so it never enters _resolve(). I've reverted to the previous line.

@BigBadBurrow BigBadBurrow changed the title Latest code change causes Latest code change causes rounds to not resolve Jan 23, 2019
@bdach
Copy link
Contributor

bdach commented Jan 25, 2019

@BigBadBurrow Thanks for the report. Could you provide a reproducer example of a game getting stuck (even a transcript of the game from the console)? It would be tremendously helpful to identifying the cause.

unaeat pushed a commit to unaeat/holdem that referenced this issue Aug 24, 2020
Fix bug that game continued if there is only one user
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants