-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: WEOS-1472 As a developer I should be able configure a session which can be used to store data #160
Open
shaniah868
wants to merge
28
commits into
dev
Choose a base branch
from
feature/WEOS-1472
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Added test for instantiating a session store -Added functionality in the security global intializer -Updated security yaml file to test it -Added a getter for the session store that is on the api
feature: WEOS-1472 Update the Security Globalization Initializer
-Update blog yaml -Update context middleware to have x-session functionality -Added a test for context middleware -Added x-session extension
-Debug some test and fix it
- Added scenarios to the feature file
feature: WEOS-1472 Update Context middleware
- Generated steps and fixed feature file background
- Filled out functionality for two steps
-Fix the import to be forked repo of gormstore
-Updated the context middleware to check for session id in the cookie and traverse through all cookies to find the one that has a valid session
-Add space to error msg
feature: WEOS-1472 Update Context middleware
- Updated feature file - E2E tests passing
Weos 1486 - Feature File and E2E test
akeemphilbert
requested changes
Apr 5, 2022
-Added the session store on the api to be the session store interface -Change context middleware to use convertstringtotype
feature: WEOS-1472 Update Context middleware
- Added more scenarios
-Updated the global initializer to have a switch to check for different types of security schemes -Added more test for check whether the security is global or on a path -Added functionality in the context middleware that checks for the security in global or path
- Added more scenarios - All E2E passing - Updated feature file as needed
feature: WEOS-1472 Update Context middleware
# Conflicts: # controllers/rest/api.go # controllers/rest/global_initializers.go # end2end_test.go
-Updated the api to get gorm connection from api -Updated yaml files to use name of db instead of title -Updated tests to use sqldatabase function to set up the gorm connection
feature: WEOS-1472 Update Context middleware
…n which can be used to store data -Added a getsession function to pull the session by id -Added test to test the getsession -Updated the context to take the session name from the environment -Added session name to os env in the global initializer
…n which can be used to store data -Ensure test passing -Added helper functions for gormstore
…n which can be used to store data -Remove the encoding on the sessionid in the cookie
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
-Data can be stored in sessions
-Once specified with the x-session extension the data that is needed is added to the context
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: