Uploads are corrupt

[rrthomas]

Whenever I upload a file using ghup, the resulting download is shorter than the file I uploaded.

[wereHamster]

Does this always happen, with all files? Or just certain files? What is your OS/ruby version?

[rrthomas]

As far as I can tell it happens with all files. I'm using Ubuntu 12.04 with ruby 1.9.3.0.

[wereHamster]

I've just merged (a rather old) pull request which slightly changes the way how files are uploaded. Maybe it fixes your problem. Can you try with the latest version?

[rrthomas]

This doesn't help (just tried), but it's not a surprise, as the file utility does exist on my platform, and files are always read as binary (the fixes are for non-UNIX platforms).

[rrthomas]

Scratch that: the update appears to make it work. Search me how it works, for the above reasons, but it seems to. (The first time I tried and failed I was running with the wrong version of github-upload.)

[wereHamster]

Could it be that files are not always read as binary, and that there is indeed a difference between #read and #binread even on unix?

[rrthomas]

If some kind of text encoding comes into play; I'm no Ruby expert.