Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed relevant variable type to unsigned, changed Material class to a struct and implemented return fast policy inside intersection.hpp #38

Merged
merged 3 commits into from
Jul 28, 2022
Merged

Changed relevant variable type to unsigned, changed Material class to a struct and implemented return fast policy inside intersection.hpp #38

merged 3 commits into from
Jul 28, 2022

Conversation

KartikDhawaniya
Copy link
Contributor

Addressin issue #25

@KartikDhawaniya KartikDhawaniya changed the title Addressing issue#25 Caned relevant variable type to unsigned, changed Material class to a struct and implemented return fast policy inside intersection.hpp Jul 28, 2022
@KartikDhawaniya KartikDhawaniya changed the title Caned relevant variable type to unsigned, changed Material class to a struct and implemented return fast policy inside intersection.hpp Changed relevant variable type to unsigned, changed Material class to a struct and implemented return fast policy inside intersection.hpp Jul 28, 2022
wermos
wermos requested changes Jul 28, 2022
View reviewed changes
Copy link
Owner

@wermos wermos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else looks good. I'm not being too pedantic with the intersection.hpp file because we are planning on having Mahesh remove it anyways.

utilities/include/color.hpp Outdated Show resolved Hide resolved
wermos
wermos requested changes Jul 28, 2022
View reviewed changes
utilities/include/color.hpp Outdated Show resolved Hide resolved
@wermos wermos merged commit 390ee9a into wermos:development Jul 28, 2022
@wermos wermos mentioned this pull request Jul 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wermos wermos wermos requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KartikDhawaniya @wermos