Skip to content

Commit

Permalink
GUI2/Addon List: restrict markup to name and installation status fields
Browse files Browse the repository at this point in the history
We don't want markup in any of the other fields. I still need to find a slightly better solution for the name
field, though. We don't want users to be able to use markup unnecessairly, but we do need markup to highlight
the names of ready-to-upload addons.

This fixes warnings about unescaped ampersands in the Author field.
  • Loading branch information
Vultraz committed Jun 22, 2017
1 parent b0effe7 commit 0276891
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 2 additions & 0 deletions data/gui/widget/addon_list.cfg
Expand Up @@ -219,6 +219,7 @@
linked_group = "name"
wrap = true
characters_per_line = 20
use_markup = true
[/label]
[/column]

Expand All @@ -237,6 +238,7 @@
id = "installation_status"
definition = "default_small"
linked_group = "name"
use_markup = true
[/label]
[/column]

Expand Down
2 changes: 0 additions & 2 deletions src/gui/widgets/addon_list.cpp
Expand Up @@ -129,8 +129,6 @@ void addon_list::set_addons(const addons_list& addons)
std::map<std::string, string_map> data;
string_map item;

item["use_markup"] = "true";

if(!tracking_info.can_publish) {
item["label"] = addon.display_icon();
data.emplace("icon", item);
Expand Down

0 comments on commit 0276891

Please sign in to comment.