Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
GUI2: changed hotkey callback return value to void
The bool retval was presumably meant to allow stopping execution of the main hotkey callbacks if a local one was meant to take precedence. However, that wasn't used anywhere (all callbacks were returning true) and the return value just meant we had to create lambdas or wrapper functions everywhere. If necessary, we can re-add halt functionality later. I did leave sdl_event_handler::hotkey_pressed returning a bool value, though, except now it signals whether there was a valid dispatcher with which to execute the hotkey callback. This seemed reasonable since we probably wouldn't want to continue if there were no dispatcher anyway, though this only has any effect in the key_down handler.
- Loading branch information
1 parent
6e401eb
commit 033b69f
Showing
6 changed files
with
24 additions
and
46 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters