Avoid temporary object when creating new textures from disk

wesnoth · Jul 31, 2017 · 13995ce · 13995ce
1 parent 6062b6c
commit 13995ce
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/src/image.cpp b/src/image.cpp
@@ -1314,8 +1314,7 @@ static texture create_texture_from_file(const image::locator& loc)
 
 		// TODO: if we need to use SDL_RWops we should use IMG_LoadTexture_RW here instead.
 		{
-			texture temp(IMG_LoadTexture(renderer, location.c_str()));
-			res = temp;
+			res.assign(IMG_LoadTexture(renderer, location.c_str()));
 		}
 
 		// TODO: decide what to do about this.