Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix my fix to my fix (fixup 0990613)
@gfgtdf Turns out I forgot to consider the old village being unassigned, which would make the exception on getting the old team a common occurrence. I've changed the code to continue on if it can't unassign the village. I also noticed a slight semantic change: unassignment of the old side used to be skipped if the new was defeated, but now it's not. Dunno if that's a big deal.
- Loading branch information
908b936
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well i don't really have an opinion on which behviour is better, but unless you have good reason to change it it should not be changed.
more importantly, it still has a bug: below it uses a 4-th arument but never a 3-th argument.
908b936
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't feel it's worth reverting to the old behavior on that one point.
908b936
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vultraz You asked:
How many fixes would a good fix fix?
It would fix and fix as much as it could, if a good fix could fix good.
908b936
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @gfgtdf on restoring the old behaviour (where attempting to assign to a defeated side has no effect).
908b936
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
God dammit all to hell.
908b936
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HERE: 1196225