Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
push end_play_exceptions one down in call stack, at "play_turn()"
Continues trend of previous commit. play_turn becomes no throw with respect to these exceptions, and so we can switch calls to it to use the "PROPOGATE_END_PLAY_SIGNAL" instead of "HANDLE_...". It looks like by progressively doing this and unit testing at each step, we will be able to successfully convert all of the functions in play_controller to use PROPOGATE, which is a cheap if else and not an exception handler, and increase the stability of the engine by avoiding the use of exceptions for control flow. If we continue this way, we could push all the throws into the event handler and the replay module. Perhaps could continue from there, but likely at some point the exceptions might be the simpler solution esp. for breaking recursion in WML / lua or things like this.
- Loading branch information
Showing
2 changed files
with
13 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters