Skip to content

Commit

Permalink
MP Lobby: avoid unnecessary cache rebuild if no required addons were …
Browse files Browse the repository at this point in the history
…installed

I was unconditionally reloading the cache even if there were a reason ad_hoc_addon_fetch_session
failed. The cache will no longer be reloaded if said function didn't actually install anything.

Fixes #2477.
  • Loading branch information
Vultraz committed Feb 11, 2018
1 parent edd6b8d commit c5e95d3
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions src/gui/dialogs/multiplayer/lobby.cpp
Expand Up @@ -262,9 +262,7 @@ bool handle_addon_requirements_gui(const std::vector<mp::game_info::required_add

if(gui2::show_message(e_title, err_msg, message::yes_no_buttons, true) == gui2::window::OK) {
// Begin download session
ad_hoc_addon_fetch_session(needs_download);

return true;
return ad_hoc_addon_fetch_session(needs_download);
}
}

Expand Down

0 comments on commit c5e95d3

Please sign in to comment.