Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Game Events: ensure event names are properly standardized in the config
This ensures all names are always valid to use in by-name lookup and are stored consistently. Also fixes a potential issue in 2c12d13. I should have called standardize_name on each name entry in the cleanup phase like when done in the registration phase, but this commit ensures that's not needed anymore.
- Loading branch information
Showing
3 changed files
with
26 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e5cea35
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this lookis like it might break spaces in inline formula (
name = "turn $($num_turns - 1)"
) or an even easier exampleturn $num_turns end"
which would becometurn_$num_turns_end"
e5cea35
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @gfgtdf has a point.
e5cea35
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
God dammit