Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assertion failure: future move + shroud + planning mode (GNA #25277) #1599

Closed
wesnoth-bugs opened this issue May 8, 2017 · 7 comments
Closed
Labels
Bug Issues involving unexpected behavior. Whiteboard Issues with the Planning Mode (a.k.a. Whiteboard) feature.

Comments

@wesnoth-bugs
Copy link

Original submission by matthiaskrgr on 2016-11-09

have map with shroud

make sure shroud updates are delayed

move unit to farthest edge of shroud it can reach in 2 turns

start planning mode

=>

wesnoth: /home/matthias/vcs/github/wesnoth/src/actions/undo.cpp:488: bool actions::undo_list::apply_shroud_changes() const: Assertion `synced_context::is_synced()' failed.

(Reproduced on linux)
Release: v1.13.6+dev (bf0f1b4-Clean)
Priority: 5 - Normal
Severity: 3 - Normal

@wesnoth-bugs wesnoth-bugs added Bug Issues involving unexpected behavior. Linux OS-specific issues that apply to Linux-based operating systems. labels May 8, 2017
@wesnoth-bugs
Copy link
Author

Modified on 2016-11-10

gfgtdf wrote:

please give a stacktrace of this asertion failure.

@wesnoth-bugs
Copy link
Author

wesnoth-bugs commented May 8, 2017

Modified on 2016-11-10

matthiaskrgr added attachment: assert_failure_shroud.log

@wesnoth-bugs
Copy link
Author

Modified on 2016-11-10

gfgtdf wrote:

thx for this stacktrace, form looking at the code it seems like the whiteboard is generally incompatible with the normal undo system. Meaning that when you 'execute' a planned move, you cannot undo it, even if the map uses nigher fog or shroud is this correct?

@Wedge009 Wedge009 added Whiteboard Issues with the Planning Mode (a.k.a. Whiteboard) feature. and removed Linux OS-specific issues that apply to Linux-based operating systems. labels May 9, 2017
@gfgtdf
Copy link
Contributor

gfgtdf commented Jul 12, 2017

the assert_failure_shroud.log file cannot be seen anyore.

@Wedge009
Copy link
Member

Wedge009 commented May 2, 2018

I can still access the log file just now.

@gfgtdf
Copy link
Contributor

gfgtdf commented May 2, 2018

ye celmin fixed that link

gfgtdf added a commit to gfgtdf/wesnoth that referenced this issue May 2, 2018
fixes wesnoth#1599 . we now automaticllay disable dsu when enabling planning mode
gfgtdf added a commit to gfgtdf/wesnoth that referenced this issue May 3, 2018
fixes wesnoth#1599 . we now automaticllay disable dsu when enabling planning mode
gfgtdf added a commit that referenced this issue May 3, 2018
fixes #1599 . we now automaticllay disable dsu when enabling planning mode
@gfgtdf
Copy link
Contributor

gfgtdf commented May 3, 2018

fixed in 5412a24

@gfgtdf gfgtdf closed this as completed May 3, 2018
Vultraz pushed a commit that referenced this issue May 3, 2018
fixes #1599 . we now automaticllay disable dsu when enabling planning mode
jostephd pushed a commit to jostephd/wesnoth that referenced this issue Oct 6, 2018
fixes wesnoth#1599 . we now automaticllay disable dsu when enabling planning mode
jostephd pushed a commit to jostephd/wesnoth that referenced this issue Oct 7, 2018
fixes wesnoth#1599 . we now automaticllay disable dsu when enabling planning mode

(cherry-picked from commit 4f161d8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues involving unexpected behavior. Whiteboard Issues with the Planning Mode (a.k.a. Whiteboard) feature.
Projects
None yet
Development

No branches or pull requests

3 participants