Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimap reveals shroud prematurely when vision points are less than MP (GNA #25622) #1645

Closed
wesnoth-bugs opened this issue May 8, 2017 · 9 comments
Labels
Bug Issues involving unexpected behavior. UI User interface issues, including both back-end and front-end issues.
Milestone

Comments

@wesnoth-bugs
Copy link

Original submission by shiki on 2017-03-23

(Reproduced on Archlinux)
Release: 1.12 / 1.13.7+dev
Priority: 5 - Normal
Severity: 3 - Normal

@wesnoth-bugs wesnoth-bugs added Bug Issues involving unexpected behavior. Linux OS-specific issues that apply to Linux-based operating systems. labels May 8, 2017
@wesnoth-bugs
Copy link
Author

wesnoth-bugs commented May 8, 2017

Modified on 2017-03-23

shiki wrote:

When a unit has more movement points than vision points, it is showing the shrouded area on the minimap too.

I think it is good that it's not revealing the shroud, but the minimap shouldn't do so either.

I submitted this to early, can someone adjust change the title?

(file #29900)

shiki added attachment: minimap.png

minimap

@wesnoth-bugs
Copy link
Author

Modified on 2017-03-23

shiki wrote:

Note: The unit has to be selected for this.

@wesnoth-bugs
Copy link
Author

Modified on 2017-03-23

wedge009 wrote:

How does a unit see more than it can move? I thought that is a standard game-play rule. Is this from a custom unit? The only time I can think that movement would be impaired is if an enemy is in your way, but the vision should be impaired too.

I did a quick check of the above scenario and found the mini-map followed the main map in its shroud-revealing behaviour.

wedge009 changed title: Minimap -> Minimap reveals shroud prematurely

@wesnoth-bugs
Copy link
Author

Modified on 2017-03-24

shiki wrote:

It's the other way around, she can move more than she can see.

For the unit_type exists the movement key and the vision key. By default that is the same, I doubt that really somebody is using the vision key. In this case I gave her more moves with debug mode.

@wesnoth-bugs
Copy link
Author

wesnoth-bugs commented May 8, 2017

Modified on 2017-03-24

wedge009 wrote:

Ah, debug mode thing. That's why I couldn't test it.

But yes, standard rule is movement = vision.

@Wedge009 Wedge009 added UI User interface issues, including both back-end and front-end issues. and removed Linux OS-specific issues that apply to Linux-based operating systems. labels May 9, 2017
@sevu
Copy link
Member

sevu commented Sep 8, 2017

I just saw that this doesn't happen in 1.12

@CelticMinstrel CelticMinstrel modified the milestones: 1.13.9, 1.14.0, 1.13.10 Sep 9, 2017
@CelticMinstrel
Copy link
Member

We should try to get this fixed for 1.14.

@CelticMinstrel CelticMinstrel changed the title Minimap reveals shroud prematurely (GNA #25622) Minimap reveals shroud prematurely when vision points are less than MP (GNA #25622) Sep 9, 2017
jostephd added a commit to jostephd/wesnoth that referenced this issue Oct 30, 2017
…es that can be moved to but aren't yet visible.

Fixes wesnoth#1645.
@jostephd
Copy link
Member

Submitted #2150

Vultraz pushed a commit that referenced this issue Oct 31, 2017
…es that can be moved to but aren't yet visible.

Fixes #1645.
@jostephd
Copy link
Member

jostephd commented Nov 1, 2017

An easy way to test this is by running 'wesnoth -t' and clicking on the Elvish Rider at (8,11).

GregoryLundberg pushed a commit that referenced this issue Nov 30, 2017
…es that can be moved to but aren't yet visible.

Fixes #1645.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues involving unexpected behavior. UI User interface issues, including both back-end and front-end issues.
Projects
None yet
Development

No branches or pull requests

5 participants