Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Lit Stone Wall terrain in favor of a Torches overlay #2087

Closed
Vultraz opened this issue Oct 9, 2017 · 5 comments
Closed

Remove Lit Stone Wall terrain in favor of a Torches overlay #2087

Vultraz opened this issue Oct 9, 2017 · 5 comments
Assignees
@doofus-01
Labels
Graphics Issues that involve the graphics engine or assets.

Comments

@Vultraz
Copy link
Member

Vultraz commented Oct 9, 2017

Even with the introduction of all these wall variants, only the Stone Wall has a lit variant. It'd be stupid to create Lit variants for every single wall, so I propose making the torches an overlay so they can be used with any wall.
@doofus-01
Copy link
Member

That's not a bad idea. It will require starting from scratch though, so it won't get done tonight. A general "torch/sconce image-set" would be useful in all sorts of instances.

@Vultraz
Copy link
Member Author

Vultraz commented Oct 9, 2017 •
edited
Loading

On second thought, the Lit Stone Walls terrain should probably be kept around for legacy purposes even if the new Torches overlay is added.

@Vultraz
Copy link
Member Author

Vultraz commented Oct 9, 2017

BTW, if you're redrawing the torches from scratch, might I suggest you make them larger than the current ones? Right now they're rather small.

@Wedge009 Wedge009 added the Graphics Issues that involve the graphics engine or assets. label Oct 10, 2017
@doofus-01
Copy link
Member

General FYI that I'm working on this in PR #2103

@doofus-01
Copy link
Member

Commit 2a79475 addresses this, correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@doofus-01 doofus-01

Labels
Graphics Issues that involve the graphics engine or assets.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Vultraz @doofus-01 @Wedge009