New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Lit Stone Wall terrain in favor of a Torches overlay #2087

Closed
Vultraz opened this Issue Oct 9, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@Vultraz
Member

Vultraz commented Oct 9, 2017

Even with the introduction of all these wall variants, only the Stone Wall has a lit variant. It'd be stupid to create Lit variants for every single wall, so I propose making the torches an overlay so they can be used with any wall.

@doofus-01

This comment has been minimized.

Show comment
Hide comment
@doofus-01

doofus-01 Oct 9, 2017

Member

That's not a bad idea. It will require starting from scratch though, so it won't get done tonight. A general "torch/sconce image-set" would be useful in all sorts of instances.

Member

doofus-01 commented Oct 9, 2017

That's not a bad idea. It will require starting from scratch though, so it won't get done tonight. A general "torch/sconce image-set" would be useful in all sorts of instances.

@Vultraz

This comment has been minimized.

Show comment
Hide comment
@Vultraz

Vultraz Oct 9, 2017

Member

On second thought, the Lit Stone Walls terrain should probably be kept around for legacy purposes even if the new Torches overlay is added.

Member

Vultraz commented Oct 9, 2017

On second thought, the Lit Stone Walls terrain should probably be kept around for legacy purposes even if the new Torches overlay is added.

@Vultraz

This comment has been minimized.

Show comment
Hide comment
@Vultraz

Vultraz Oct 9, 2017

Member

BTW, if you're redrawing the torches from scratch, might I suggest you make them larger than the current ones? Right now they're rather small.

Member

Vultraz commented Oct 9, 2017

BTW, if you're redrawing the torches from scratch, might I suggest you make them larger than the current ones? Right now they're rather small.

@Wedge009 Wedge009 added the Graphics label Oct 10, 2017

@doofus-01

This comment has been minimized.

Show comment
Hide comment
@doofus-01

doofus-01 Oct 15, 2017

Member

General FYI that I'm working on this in PR #2103

Member

doofus-01 commented Oct 15, 2017

General FYI that I'm working on this in PR #2103

@doofus-01

This comment has been minimized.

Show comment
Hide comment
@doofus-01

doofus-01 Oct 20, 2017

Member

Commit 2a79475 addresses this, correct?

Member

doofus-01 commented Oct 20, 2017

Commit 2a79475 addresses this, correct?

@doofus-01 doofus-01 closed this Oct 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment