Assertion Failure for AI with two leaders - src/attack_prediction.cpp:1763

[doofus-01]

On v1.13.10+dev (f6c4f3d), the program aborts with assertion failure:
wesnoth: src/attack_prediction.cpp:1763: double {anonymous}::calculate_probability_of_debuff(double, bool, double, double, bool, double): Assertion 'prob_touched >= 0.0 && prob_touched <= 1.0' failed. Aborted (core dumped)
when the AI has control of a side with two leaders, each with their own 'extra_recruit' lists, but the side recruit list is empty.

Such a situation used to work just fine, I'm not sure when this first became a problem - I think it was OK in 1.13.8, but I'm not sure.

I'm attaching a demonstration scenario. If you modify the map to remove the secondary keeps (the encampments), the game does not abort. Campaign is found in list with name "Empty Recruit List".
Demo_Camp_D.zip

[doofus-01]

@jyrkive - Well, it is fixed, but your description seems unrelated to the situation I described. If the recruit lists and keeps business (no enemy required, within range at least) makes sense to you, it's all good. Just bringing it up in case this is suppressing a symptom of something that will flare up again later.

[jyrkive]

My description is about the actual cause of the bug, which I found out by debugging in your test scenario. Your guess about two leaders was incorrect. (Indeed, attack prediction code doesn't even know how many leaders you have.)

[doofus-01]

Well, I only know when it showed up, and your description still doesn't apply to what I saw (who was dying? -> no one. Why do the secondary keeps matter? Why does changing the recruit list matter?)
But I'm not a programmer, so I wouldn't understand.

[jyrkive]

It was in attack prediction. It predicted that one combatant was 100% guaranteed to die in a future fight if it were to occur.

[doofus-01]

EDIT: I've made a mess of this, I'll post my question on the forums. Maybe someone there will have an answer.
EDIT: Actually, I have wasted too much time on this, but I'll just summarize to say that the recruitment does matter, despite what jyrkive says; you can get the same combo of units on the map or recruited and it crashes or doesn't based on recruit vs extra_recruit. But screw it, not my problem.