Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small wall-castle transition issue #2190

Closed
Vultraz opened this issue Nov 12, 2017 · 7 comments
Closed

Small wall-castle transition issue #2190

Vultraz opened this issue Nov 12, 2017 · 7 comments
Assignees
Labels
Bug Issues involving unexpected behavior. Graphics Issues that involve the graphics engine or assets. Ready for testing Issues for which a potential fix is available but untested.

Comments

@Vultraz
Copy link
Member

Vultraz commented Nov 12, 2017

See below:
transition issue

@doofus-01 @ln-zookeeper perhaps either of you know how this could be fixed? The brazier makes no difference, BTW.

@Vultraz Vultraz added Graphics Issues that involve the graphics engine or assets. Bug Issues involving unexpected behavior. labels Nov 12, 2017
@doofus-01
Copy link
Member

I think I know what the problem is, though the fix might cause trouble... It's like one of those sliding tile puzzles. If zookeeper doesn't get to it, I'll try to have something within the week.

@doofus-01 doofus-01 self-assigned this Nov 12, 2017
@doofus-01
Copy link
Member

doofus-01 commented Nov 13, 2017

It's a problem with base key and rotations. Unfortunately, changing the base so that the wall corner image is above the castle wall results in other layering glitches.
I can change the base key at line 2556 of new-macros.cfg to get the glitch to go away, but it might cause other issues. I don't see any though, so I'll just go ahead and do that...

doofus-01 added a commit that referenced this issue Nov 13, 2017
@doofus-01 doofus-01 added the Ready for testing Issues for which a potential fix is available but untested. label Nov 13, 2017
@Vultraz
Copy link
Member Author

Vultraz commented Nov 13, 2017

I'm not seeing any difference even with your change :/

@doofus-01
Copy link
Member

doofus-01 commented Nov 13, 2017

Yes, seems like that didn't catch all cases. (I don't know how the issue got closed...)

@doofus-01 doofus-01 reopened this Nov 13, 2017
@doofus-01
Copy link
Member

Try it now?

@Vultraz
Copy link
Member Author

Vultraz commented Nov 13, 2017

Confirmed fixed \o/

@Vultraz Vultraz closed this as completed Nov 13, 2017
@CelticMinstrel
Copy link
Member

@doofus-01 – The issue got closed because your commit message contained the string "fix #2190". If you're not sure the fix works and you want to leave the issue open, you should either use a different word (eg something like "partially addresses #2190") or rephrase it to place something between (eg "partial fix for #2190").

GregoryLundberg pushed a commit that referenced this issue Nov 30, 2017
GregoryLundberg pushed a commit that referenced this issue Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues involving unexpected behavior. Graphics Issues that involve the graphics engine or assets. Ready for testing Issues for which a potential fix is available but untested.
Projects
None yet
Development

No branches or pull requests

3 participants