Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
OOS in multiplayer when [modify_side] changes a controller during "side_turn_end" event. #2563
if a code like
is executed during an "side_turn_end" OOS can happen (assumng that side was previously null-controlled)
well before 1.13.2 (2d80c97) we lived fine without support for [modify_side] controller= in mp at all unrelated to in which event it happens, so this is clearly not a blocker. I still think it'd be nice to have it since there is no reason why using it in turn end event would make less sense than in any other event.
I also didn't find any cases in mainline campaign that ere effected by it (i did find a possible invalid [filter] though in https://github.com/wesnoth/wesnoth/blob/1.13.11/data/campaigns/Two_Brothers/scenarios/02_The_Chase.cfg#L423)
EDIT: i just found my first commit that fixes [modify_side] controller= in MP. 6dee136 . It also gives us a testing scenario for this one, just replace