Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In mp games, rename "Quit to Titlescreen" to "Quit to Lobby" #2744

Closed
blarum opened this issue Mar 24, 2018 · 3 comments · Fixed by #5565
Closed

In mp games, rename "Quit to Titlescreen" to "Quit to Lobby" #2744

blarum opened this issue Mar 24, 2018 · 3 comments · Fixed by #5565
Labels
Enhancement Issues that are requests for new features or changes to existing ones. UI User interface issues, including both back-end and front-end issues.

Comments

@blarum
Copy link

blarum commented Mar 24, 2018

From a mp game, "Quit to Titlescreen" from the "Menu" menu in the top left, quits to lobby instead, so it should be renamed to "Quit to Lobby". In local games, "Quit to Titlescreen" does what it says.

@Vultraz Vultraz added Enhancement Issues that are requests for new features or changes to existing ones. UI User interface issues, including both back-end and front-end issues. labels Mar 25, 2018
@Vultraz
Copy link
Member

Vultraz commented Mar 25, 2018

Unfortunately, it seems the hotkey system doesn't currently support this. Will need to make some changes.

@CelticMinstrel
Copy link
Member

Or you could hard-code a special case. >_>

@gfgtdf
Copy link
Contributor

gfgtdf commented Mar 26, 2018

Or you could hard-code a special case. >_>

for 1.14 this is probably the best option.

irydacea added a commit to irydacea/wesnoth that referenced this issue Feb 20, 2021
Something that people occasionally miss is that several hotkey actions
double as menu items throughout the UI. Menu items have this pecular
quality to them that requires them to be as succinct as possible to make
their meaning apparent without requiring excessive reading and parsing
from users/players. Furthermore, in a UI like ours with large elements
everywhere,  we want to avoid excessively wordy elements that can become
ten times as long when translated into foreign languages.

Commit c42bf11 replaced the Preferences
label with a unnecessarily longer version despite it being pretty
standard among most applications for it to be a single word (either
Preferences or Options or Settings). This commit reverts that.

Clear Chat and Errors (also from the aforementioned commit) is relabeled
Clear Chat rather than Clear Messages so it's clearer that it applies to
chat messages in particular and not anything else. On that note, the
fact that game diagnostics share real estate and infrastructure with
chat is really unfortunate but there's not much that can be done about
it at the moment. At least it is visually obvious that this is the case,
and most people will not normally see errors unless they are playing
broken content -- in this case, it should be in our best interest to
annoy them as much as possible so they will report the errors back to
the authors, so we don't need to make the relevant menu action this
verbose.

View Chat Log is relabeled Chat Log since no other option deals with the
Chat *Log* in particular.

Additionally, the Quit to Main Menu action is relabeled just Quit to
Menu, which is closer to what the option actually does in MP games (quit
to lobby) without being inaccurate in either SP or MP.

Closes wesnoth#2744.
irydacea added a commit to irydacea/wesnoth that referenced this issue Feb 20, 2021
Something that people occasionally miss is that several hotkey actions
double as menu items throughout the UI. Menu items have this particular
quality to them that requires them to be as succinct as possible to make
their meaning apparent without requiring excessive reading and parsing
from users/players. Furthermore, in a UI like ours with large elements
everywhere,  we want to avoid excessively wordy elements that can become
ten times as long when translated into foreign languages.

Commit c42bf11 replaced the Preferences
label with a unnecessarily longer version despite it being pretty
standard among most applications for it to be a single word (either
Preferences or Options or Settings). This commit reverts that.

Clear Chat and Errors (also from the aforementioned commit) is relabeled
Clear Chat rather than Clear Messages so it's clearer that it applies to
chat messages in particular and not anything else. On that note, the
fact that game diagnostics share real estate and infrastructure with
chat is really unfortunate but there's not much that can be done about
it at the moment. At least it is visually obvious that this is the case,
and most people will not normally see errors unless they are playing
broken content -- in this case, it should be in our best interest to
annoy them as much as possible so they will report the errors back to
the authors, so we don't need to make the relevant menu action this
verbose.

View Chat Log is relabeled Chat Log since no other option deals with the
Chat *Log* in particular.

Additionally, the Quit to Main Menu action is relabeled just Quit to
Menu, which is closer to what the option actually does in MP games (quit
to lobby) without being inaccurate in either SP or MP.

Closes wesnoth#2744.
irydacea added a commit to irydacea/wesnoth that referenced this issue Feb 20, 2021
Something that people occasionally miss is that several hotkey actions
double as menu items throughout the UI. Menu items have this particular
quality to them that requires them to be as succinct as possible to make
their meaning apparent without requiring excessive reading and parsing
from users/players. Furthermore, in a UI like ours with large elements
everywhere,  we want to avoid excessively wordy elements that can become
ten times as long when translated into foreign languages.

Commit c42bf11 replaced the Preferences
label with a unnecessarily longer version despite it being pretty
standard among most applications for it to be a single word (either
Preferences or Options or Settings). This commit reverts that.

Clear Chat and Errors (also from the aforementioned commit) is relabeled
Clear Chat rather than Clear Messages so it's clearer that it applies to
chat messages in particular and not anything else. On that note, the
fact that game diagnostics share real estate and infrastructure with
chat is really unfortunate but there's not much that can be done about
it at the moment. At least it is visually obvious that this is the case,
and most people will not normally see errors unless they are playing
broken content -- in this case, it should be in our best interest to
annoy them as much as possible so they will report the errors back to
the authors, so we don't need to make the relevant menu action this
verbose.

View Chat Log is relabeled Chat Log since no other option deals with the
Chat *Log* in particular.

Scenario Objectives is relabeled Objectives because there really isn't
anything else that has objectives we can look at in the whole game.

Enter User Command is relabeled Enter Command so as to not sound
superfluous.

Additionally, the Quit to Main Menu action is relabeled just Quit to
Menu, which is closer to what the option actually does in MP games (quit
to lobby) without being inaccurate in either SP or MP (closes wesnoth#2744).
irydacea added a commit to irydacea/wesnoth that referenced this issue Feb 20, 2021
Something that people occasionally miss is that several hotkey actions
double as menu items throughout the UI. Menu items have this particular
quality to them that requires them to be as succinct as possible to make
their meaning apparent without requiring excessive reading and parsing
from users/players. Furthermore, in a UI like ours with large elements
everywhere,  we want to avoid excessively wordy elements that can become
ten times as long when translated into foreign languages.

Commit c42bf11 replaced the Preferences
label with a unnecessarily longer version despite it being pretty
standard among most applications for it to be a single word (either
Preferences or Options or Settings). This commit reverts that.

Clear Chat and Errors (also from the aforementioned commit) is relabeled
Clear Chat rather than Clear Messages so it's clearer that it applies to
chat messages in particular and not anything else. On that note, the
fact that game diagnostics share real estate and infrastructure with
chat is really unfortunate but there's not much that can be done about
it at the moment. At least it is visually obvious that this is the case.
It's also rarely relevant (and most people won't think of entering
"error" into the hotkey filter before reporting the error somewhere).

View Chat Log is relabeled Chat Log since no other option deals with the
Chat *Log* in particular.

Scenario Objectives is relabeled Objectives because there really isn't
anything else that has objectives we can look at in the whole game.

Enter User Command is relabeled Enter Command so as to not sound
superfluous.

Additionally, the Quit to Main Menu action is relabeled just Quit to
Menu, which is closer to what the option actually does in MP games (quit
to lobby) without being inaccurate in either SP or MP (closes wesnoth#2744).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Issues that are requests for new features or changes to existing ones. UI User interface issues, including both back-end and front-end issues.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants