Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug in [disable] filters #2801

Closed
gfgtdf opened this issue Mar 31, 2018 · 1 comment
Closed

bug in [disable] filters #2801

gfgtdf opened this issue Mar 31, 2018 · 1 comment
Labels
Blocker: New Stable Issues that must be resolved prior to the next stable series being released. Bug Issues involving unexpected behavior. WML Issues involving the WML engine or WML APIs.
Milestone
1.14.0

Comments

@gfgtdf
Copy link
Contributor

gfgtdf commented Mar 31, 2018 •
edited

see https://forums.wesnoth.org/viewtopic.php?f=21&t=47742&start=15#p625354

It probably this line https://github.com/wesnoth/wesnoth/blob/1.13.12/src/gui/dialogs/unit_attack.cpp#L125 see also #2526
@gfgtdf gfgtdf added Bug Issues involving unexpected behavior. WML Issues involving the WML engine or WML APIs. labels Mar 31, 2018
@gfgtdf
Copy link
Contributor Author

gfgtdf commented Apr 1, 2018

makring as a blocker since this seems to break existing addons and is probably rather easy to fix.

@gfgtdf gfgtdf added the Blocker: New Stable Issues that must be resolved prior to the next stable series being released. label Apr 1, 2018
@gfgtdf gfgtdf added this to the 1.14.0 milestone Apr 2, 2018
@gfgtdf gfgtdf mentioned this issue Apr 3, 2018
Merged
gfgtdf added a commit that referenced this issue Apr 3, 2018
@gfgtdf
fix filter not working in [disable] (#2826)
6500794 
The problem was that the specials_context was not set during those
two get_special_bool calls

This removes what seems to be a rather useless optimisation in
battle_context::battle_context since choose_attacker_weapon would
just return 0 in that case.

fixes #2801
@Vultraz Vultraz closed this as completed in c4cf0c9 Apr 3, 2018
jostephd pushed a commit to jostephd/wesnoth that referenced this issue Oct 6, 2018
@gfgtdf @jostephd
fix filter not working in [disable] (wesnoth#2826)
e863fbf 
The problem was that the specials_context was not set during those
two get_special_bool calls

This removes what seems to be a rather useless optimisation in
battle_context::battle_context since choose_attacker_weapon would
just return 0 in that case.

fixes wesnoth#2801
jostephd pushed a commit to jostephd/wesnoth that referenced this issue Oct 7, 2018
@gfgtdf @Vultraz
fix filter not working in [disable] (wesnoth#2826)
fc79727 
The problem was that the specials_context was not set during those
two get_special_bool calls

This removes what seems to be a rather useless optimisation in
battle_context::battle_context since choose_attacker_weapon would
just return 0 in that case.

fixes wesnoth#2801

(cherry-picked from commit c4cf0c9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Blocker: New Stable Issues that must be resolved prior to the next stable series being released. Bug Issues involving unexpected behavior. WML Issues involving the WML engine or WML APIs.
Projects
None yet
Milestone
1.14.0
Development

No branches or pull requests
1 participant
@gfgtdf