"has left the game" dialog says the player name, but not the side

[stevecotton]

The behaviour of the dialog itself hasn't changed from 1.12.6, but the timing of the server chat messages has. This issue probably only matters where there's more than 2 players in the game.

Call the players "Host" and "Quitter", assuming Quitter had both side 2 and side 4.

On 1.12.6, Host sees this

• chat message: Quitter has left the game
• chat message: Host takes control of side 2
• dialog for control/droid that says "Quitter has left the game", without saying which side
• chat message: Host takes control of side 4
• dialog for control/droid that says "Quitter has left the game", without saying which side

On 1.13.13, Host sees this

• dialog for control/droid that says "Quitter has left the game", without saying which side
• chat message: Quitter has left the game
• chat message: Host takes control of side 2
• chat message: Host takes control of side 4
• dialog for control/droid that says "Quitter has left the game", without saying which side

[gfgtdf]

hmm ye that dialgo shodul say for which side the side it's reassigned, bot for 1.14 we have a stringfreeze. But you coudl fix it for master then we coudl backport it for 1.14.1 .

I think it's save to assume that the host get the dialog for all side that that client controlled in order, and in most cases you probably want to do the same with all those sides anyways. So not a blocker for 1.14 i'd say.

[stevecotton]

Agreed, not a blocker