"lobby" chat tab has a "close" button (X)

[vgaming]

See screenshot:

Steps to repro:

• start wesnoth v1.13.14+dev (7582800-Clean)
• join MP lobby
• start creating a new game, wait till you get your own room and a chat belonging to room

It's not important, but I think it's a bug nevertheless.

[Wedge009]

Agreed it's trivial but still worth reporting - I'd expect Lobby isn't meant to be ever closed so it shouldn't have a close button even if that button doesn't do anything (and the fact it doesn't do anything can be confusing).

[Vultraz]

The lobby tab in staging is hidden in 1.14.0 and later, so this isn't really relevant. But, indeed, you should never be able to close the lobby tab...

[vgaming]

@Vultraz oh, indeed.
I really don't understand why "lobby" tab was removed though. Why was it? Considering we have tabs, it makes all the sense to me to have a "lobby" tab too. Doesn't eat too much space/attention in the chat tab bar, does it?

[Wedge009]

Hmm, I must have been testing a pre-release build (still 1.14, not 1.13). Checking on the official 1.14.0 release (via Steam) as well as my 1.14 branch build as at 232715a, the close button is no longer available on the Lobby tab.

@vgaming Closing this, since I only just noticed you were testing a 1.13 build.

Edit: Lobby tab wasn't removed, just the close button for it.

[vgaming]

@Wedge009 but it is removed!

No lobby tab that I could see.
This is what actually @Vultraz said, too. "lobby tab in staging is hidden in 1.14.0 and later"

[Wedge009]

Hmm, playing 1.14.0 in Steam and 1.14.0+dev (aa772cb), the tab is still there for me. This is when in the lobby, immediately upon logging into the official server. I haven't joined any room/game yet - I notice your message says 'this game' joined. Are you saying this only happens when you join a game?

If so, that's a different issue - I agree you might want to keep the lobby open in this case, but it's different from the lobby tab having a non-functional X button on it.

[vgaming]

@Wedge009 yes, that is indeed a separate question.

Are you saying this only happens when you join a game?

Yes, "lobby" is hidden when I join any game. As far as I understood, it was done intentionally. OK, I guess I'll have to ask or raise any issues/questions about it separately. Not in this issue.

[sevu]

The X should be hidden in the main Lobby UI too.

(newest 1.14 build from the repo)

[vgaming]

@sevu yes indeed, wonder why I missed it myself when re-checking. So, still needs to be fixed.

[sevu]

It's not always shown. My theory is it's not shown the first time you launch the game and enter the lobby, but after joining a game room and returning. Plus, when leaving the MP Server and rejoining afterwards it is directly there.

[Wedge009]

It wasn't being shown in the main lobby. But if it was re-appearing after returning from a game room, then I wouldn't have seen that anyway.