Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't give "illegal map" warning in the lobby #3095

Open
gfgtdf opened this issue May 11, 2018 · 1 comment
Open

don't give "illegal map" warning in the lobby #3095

gfgtdf opened this issue May 11, 2018 · 1 comment
Labels
Enhancement Issues that are requests for new features or changes to existing ones. MP Lobby Issues with the multiplayer lobby UI and its components.

Comments

@gfgtdf
Copy link
Contributor

gfgtdf commented May 11, 2018 •
edited

since the lobby might attempt to print maps for games that require additional not-installed addons encountering unknown tiles there is not unexpected at all and should not print an error. Currently i am getting quite soem of these erros messages:

20180512 01:07:53 error config: Error while loading the map: Unknown tile in map: (Ur^Iim) 'Ur^Iim'
20180512 01:07:53 error config: Error while loading the map: Unknown tile in map: (Ur^Iim) 'Ur^Iim'
20180512 01:07:54 error config: Error while loading the map: Unknown tile in map: (Ur^Iim) 'Ur^Iim'
20180512 01:07:54 error config: Error while loading the map: Unknown tile in map: (Ur^Iim) 'Ur^Iim'
20180512 01:07:55 error config: Error while loading the map: Unknown tile in map: (Ur^Iim) 'Ur^Iim'
20180512 01:07:55 error config: Error while loading the map: Unknown tile in map: (Ur^Iim) 'Ur^Iim'
20180512 01:09:07 error config: illegal map: Unknown tile in map: (Ur^Iim) 'Ur^Iim'
20180512 01:09:07 error config: illegal map: Unknown tile in map: (Ur^Iim) 'Ur^Iim'
20180512 01:09:52 error config: illegal map: Unknown tile in map: (Ur^Iim) 'Ur^Iim'
20180512 01:11:40 error config: illegal map: Unknown tile in map: (Ur^Iim) 'Ur^Iim'
20180512 01:14:55 error config: illegal map: Unknown tile in map: (Ur^Iim) 'Ur^Iim'
20180512 01:15:24 error config: Error while loading the map: Unknown tile in map: (Ur^Iim) 'Ur^Iim'
20180512 01:15:24 error config: Error while loading the map: Unknown tile in map: (Ur^Iim) 'Ur^Iim'
20180512 01:15:25 error config: Error while loading the map: Unknown tile in map: (Ur^Iim) 'Ur^Iim'

It's worth to note that there seem to be two different types of errormessages (Error while loading the map) and (illegal map)
@gfgtdf gfgtdf added the MP Lobby Issues with the multiplayer lobby UI and its components. label May 11, 2018
@irydacea irydacea added the Enhancement Issues that are requests for new features or changes to existing ones. label May 11, 2018
@gfgtdf gfgtdf changed the title don't give "illegal map" in the lobby don't give "illegal map" warning in the lobby May 12, 2018
Vultraz added a commit that referenced this issue May 12, 2018
@Vultraz
MP Lobby: removed "illegal map" error (see #3095)
f34db1b 
There's still the "Error while loading the map:" error emitted by the minimap
widget, but this at least curbs the duplicates.
Vultraz added a commit that referenced this issue May 12, 2018
@Vultraz
MP Lobby: removed "illegal map" error (see #3095)
6ae5194 
There's still the "Error while loading the map:" error emitted by the minimap
widget, but this at least curbs the duplicates.
@Vultraz
Copy link
Member

Vultraz commented May 12, 2018

"Error while loading the map:" is generated by the minimap widget, but I've removed "illegal map".

jostephd pushed a commit to jostephd/wesnoth that referenced this issue Oct 6, 2018
@Vultraz @jostephd
MP Lobby: removed "illegal map" error (see wesnoth#3095)
580e7b4 
There's still the "Error while loading the map:" error emitted by the minimap
widget, but this at least curbs the duplicates.
jostephd pushed a commit to jostephd/wesnoth that referenced this issue Oct 7, 2018
@Vultraz
MP Lobby: removed "illegal map" error (see wesnoth#3095)
cd566ec 
There's still the "Error while loading the map:" error emitted by the minimap
widget, but this at least curbs the duplicates.

(cherry-picked from commit f34db1b)
@jostephd jostephd mentioned this issue Oct 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Issues that are requests for new features or changes to existing ones. MP Lobby Issues with the multiplayer lobby UI and its components.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@irydacea @Vultraz @gfgtdf