Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SoF - Last Scenario bugged/not winnable #3099

Closed
Konrad22 opened this issue May 12, 2018 · 3 comments
Closed

SoF - Last Scenario bugged/not winnable #3099

Konrad22 opened this issue May 12, 2018 · 3 comments
Assignees
Labels
Blocker: New Stable Issues that must be resolved prior to the next stable series being released. Bug Issues involving unexpected behavior. Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign WML Issues involving the WML engine or WML APIs.

Comments

@Konrad22
Copy link
Contributor

https://steamcommunity.com/app/599390/discussions/0/2828702372999695509/
So, someone played until the the Vulcano Scenario (when they all die) and instead of winning after the Vulcano explodes, he loses. (More details in the link.)

@sevu sevu added Bug Issues involving unexpected behavior. Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign WML Issues involving the WML engine or WML APIs. Good first issue Issues deemed adequate for contributors without prior experience to work on. Blocker: New Stable Issues that must be resolved prior to the next stable series being released. labels May 12, 2018
@CelticMinstrel
Copy link
Member

CelticMinstrel commented May 12, 2018

Hmm, that's a really odd error; it's just looping over a list of units and killing each one, so that shouldn't change the length of the array as far as I'm aware, unless [kill] fired an event which changed said array (which I guess is actually possible since some of this is in a die event, but I'm not sure that would cause exactly nine times which seems to be once for each instance of the loop, unless the numbers matching is a red herring).

The easiest fix would probably be to just replace all the [foreach] tags over lavadead with [for] tags (which also means some small changes to the contents, like $this_item -> $lavadead[$i]).

If it's the die event causing trouble, another fix would be to use a different variable for each loop.

@sevu sevu removed the Good first issue Issues deemed adequate for contributors without prior experience to work on. label May 13, 2018
@ln-zookeeper
Copy link
Member

Couldn't the [foreach] problem be caused by the fact that it's in a nested event..? Maybe all those cases of $this_item should be $|this_item instead.

@CelticMinstrel
Copy link
Member

Hmm, I'm not sure. Certainly, if it's a nested event without delayed_variable_substitution=yes, then you'd need to use $|this_item instead of $this_item, but if that were the cause of this, surely it would've had the same problem with {FOREACH}?

ln-zookeeper added a commit that referenced this issue May 21, 2018
This merely patches the worst problems (multiple successive [endlevel] calls, inconsistent [endlevel] contents, recursive elf die event, lava fills visually broken); ideally the whole scenario should be rewritten and redesigned.

The mask changes only consist of re-sizing them to match the map size.
@ln-zookeeper ln-zookeeper self-assigned this May 21, 2018
jostephd pushed a commit to jostephd/wesnoth that referenced this issue Oct 6, 2018
This merely patches the worst problems (multiple successive [endlevel] calls, inconsistent [endlevel] contents, recursive elf die event, lava fills visually broken); ideally the whole scenario should be rewritten and redesigned.

The mask changes only consist of re-sizing them to match the map size.
jostephd pushed a commit to jostephd/wesnoth that referenced this issue Oct 7, 2018
This merely patches the worst problems (multiple successive [endlevel] calls, inconsistent [endlevel] contents, recursive elf die event, lava fills visually broken); ideally the whole scenario should be rewritten and redesigned.

The mask changes only consist of re-sizing them to match the map size.

(cherry-picked from commit c0583a1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocker: New Stable Issues that must be resolved prior to the next stable series being released. Bug Issues involving unexpected behavior. Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign WML Issues involving the WML engine or WML APIs.
Projects
None yet
Development

No branches or pull requests

4 participants