untranslatable strings in the editor

[sevu]

The ones I found:

the ones on the left are in English, the ones on thr Right are translated... Although, not in the recruit row

Maybe there are more such tooltips which I did not explore yet.

---

josteph edit:

• The strings on the left in the first screenshot
• The list of unit types after "Recruit"
• Items
• Stub Time of Day

[Wedge009]

I assume the translations are actually available in the German files. I can confirm the unit descriptions still being in English but I couldn't find the Items being stuck in English (using French translation). I also couldn't find the Stub Time of Day (I did use the time-of-day button near the mini-map).

[Wedge009]

The Identifier/Name/Type/etc labels appear to be marked for translation in https://github.com/wesnoth/wesnoth/blob/master/data/gui/window/editor_edit_scenario.cfg so something must be interfering with that.

[jostephd]

9f08efe should fix the strings on the left being untranslated. To fix the recruit list being untranslated someone would have to convert unit_it->recruits() (in the lines being changed by that commit), which is a vector of type id's, to a vector of translated type names.

[Wedge009]

Thanks, the first image is resolved now. What is N_ supposed to do anyway?

I couldn't confirm the Items or Stub things previously - requesting more details on these from @sevu, please.

[jostephd]

Thanks, the first image is resolved now. What is N_ supposed to do anyway?

N_("foo") is recognized by the gettext extractor and adds "foo" to the pot files, but as far as the compiler is concerned, it's equivalent to "foo", it doesn't have any runtime effect at all.

[jostephd]

I can reproduce the Stub Time of Day by opening a scenario that doesn't have any [time] tags at all. (Create a new scenario, save it, exit wesnoth, edit the scenario cfg file outside wesnoth to delete the [time] tags, then open the scenario in the wesnoth editor.)

[CelticMinstrel]

The purpose of N_ is for when the string will later be passed to the translation lookup... not entirely sure why that would be necessary, though.

[Wedge009]

For 'Stub Time of Day' is it just a matter of changing the N_ to _?

wesnoth/src/time_of_day.cpp

Line 45 in b4f09d1

, name(N_("Stub Time of Day"))

[jostephd]

That depends. If you change N_ to _, the translation would be retrieved when that function (the constructor) is run. You'd need to check uses of that constructor. For example, suppose the stub time_of_day object is created once when Wesnoth starts. If that is the case, then if you start Wesnoth normally, change language, and start the editor, the wrong translation would be used. In that case, we'd need to keep the N_ but call _(foo.name) on the stub time_of_day object before it's displayed.

[CelticMinstrel]

Except, don't use the _() syntax to call it in that case - _() should only be used for literal strings. Probably use the two-argument t_string constructor, or directly call one of the functions like translation::dsgettext.