observer icon at wrong location #3543
Labels
Blocker: New Stable
Issues that must be resolved prior to the next stable series being released.
Bug
Issues involving unexpected behavior.
Regression
Issues that were not present in previous releases.
UI
User interface issues, including both back-end and front-end issues.
Milestone
Comments
gfgtdf
added
Bug
sevu
added
the
Blocker: New Stable
jostephd
added a commit
that referenced
this issue
Sep 25, 2018
Closes #3543. Fixups #3441. The observers icon is declared immediately after `report_timeout`, therefore the timeout widget was the ref rect for the observers widget: https://github.com/wesnoth/wesnoth/blob/83ba09a5a98b817a3e50a89dd6b41d2f779af5ff/src/theme.cpp#L120 PR #3441 added a battery icon to the left of the timeout widget. That shifted the timeout widget to the right and the observers widget shifted along with it due to its relative positioning. The observers widget moved even on devices that didn't have a battery. Fix this by using the battery box as the ref of the observers widget, because it currently occupies the absolute location the observers widget was positioned relatively to.
|
Fixed on 1.14. The battery code hasn't been backported to master yet. |
jostephd
added a commit
to jostephd/wesnoth
that referenced
this issue
Oct 18, 2018
Closes wesnoth#3543. Fixups wesnoth#3441. The observers icon is declared immediately after `report_timeout`, therefore the timeout widget was the ref rect for the observers widget: https://github.com/wesnoth/wesnoth/blob/83ba09a5a98b817a3e50a89dd6b41d2f779af5ff/src/theme.cpp#L120 PR wesnoth#3441 added a battery icon to the left of the timeout widget. That shifted the timeout widget to the right and the observers widget shifted along with it due to its relative positioning. The observers widget moved even on devices that didn't have a battery. Fix this by using the battery box as the ref of the observers widget, because it currently occupies the absolute location the observers widget was positioned relatively to. (cherry picked from commit 461cd2c)
jostephd
added a commit
to jostephd/wesnoth
that referenced
this issue
Oct 27, 2018
Closes wesnoth#3543. Fixups wesnoth#3441. The observers icon is declared immediately after `report_timeout`, therefore the timeout widget was the ref rect for the observers widget: https://github.com/wesnoth/wesnoth/blob/83ba09a5a98b817a3e50a89dd6b41d2f779af5ff/src/theme.cpp#L120 PR wesnoth#3441 added a battery icon to the left of the timeout widget. That shifted the timeout widget to the right and the observers widget shifted along with it due to its relative positioning. The observers widget moved even on devices that didn't have a battery. Fix this by using the battery box as the ref of the observers widget, because it currently occupies the absolute location the observers widget was positioned relatively to. (cherry picked from commit 461cd2c)
jostephd
added a commit
to jostephd/wesnoth
that referenced
this issue
Oct 27, 2018
Closes wesnoth#3543. Fixups wesnoth#3441. The observers icon is declared immediately after `report_timeout`, therefore the timeout widget was the ref rect for the observers widget: https://github.com/wesnoth/wesnoth/blob/83ba09a5a98b817a3e50a89dd6b41d2f779af5ff/src/theme.cpp#L120 PR wesnoth#3441 added a battery icon to the left of the timeout widget. That shifted the timeout widget to the right and the observers widget shifted along with it due to its relative positioning. The observers widget moved even on devices that didn't have a battery. Fix this by using the battery box as the ref of the observers widget, because it currently occupies the absolute location the observers widget was positioned relatively to. (cherry picked from commit 461cd2c)
jostephd
added a commit
to jostephd/wesnoth
that referenced
this issue
Oct 28, 2018
Closes wesnoth#3543. Fixups wesnoth#3441. The observers icon is declared immediately after `report_timeout`, therefore the timeout widget was the ref rect for the observers widget: https://github.com/wesnoth/wesnoth/blob/83ba09a5a98b817a3e50a89dd6b41d2f779af5ff/src/theme.cpp#L120 PR wesnoth#3441 added a battery icon to the left of the timeout widget. That shifted the timeout widget to the right and the observers widget shifted along with it due to its relative positioning. The observers widget moved even on devices that didn't have a battery. Fix this by using the battery box as the ref of the observers widget, because it currently occupies the absolute location the observers widget was positioned relatively to. (cherry picked from commit 461cd2c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As seen in the screenshot the observer icon (the eye) is too much towards the right and hidden behind the minimap. Reproduced on 1.14.4+dev
The text was updated successfully, but these errors were encountered: