Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

observer icon at wrong location #3543

Closed
gfgtdf opened this Issue Sep 12, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@gfgtdf
Copy link
Contributor

gfgtdf commented Sep 12, 2018

As seen in the screenshot the observer icon (the eye) is too much towards the right and hidden behind the minimap. Reproduced on 1.14.4+dev

grafik

@gfgtdf gfgtdf added Bug UI labels Sep 12, 2018

@sevu sevu added the Blocker label Sep 13, 2018

@sevu sevu added this to the 1.14.5 milestone Sep 13, 2018

@sevu sevu added the Regression label Sep 13, 2018

@jostephd jostephd modified the milestones: 1.14.5, 1.14.6 Sep 25, 2018

jostephd added a commit that referenced this issue Sep 25, 2018

Themes: Fix the observers icon being hidden under the minimap
Closes #3543. Fixups #3441.

The observers icon is declared immediately after `report_timeout`,
therefore the timeout widget was the ref rect for the observers widget:
https://github.com/wesnoth/wesnoth/blob/83ba09a5a98b817a3e50a89dd6b41d2f779af5ff/src/theme.cpp#L120

PR #3441 added a battery icon to the left of the timeout widget. That
shifted the timeout widget to the right and the observers widget shifted
along with it due to its relative positioning. The observers widget
moved even on devices that didn't have a battery.

Fix this by using the battery box as the ref of the observers widget,
because it currently occupies the absolute location the observers widget
was positioned relatively to.
@jostephd

This comment has been minimized.

Copy link
Member

jostephd commented Sep 25, 2018

Fixed on 1.14. The battery code hasn't been backported to master yet.

@jostephd jostephd closed this Sep 25, 2018

jostephd added a commit to jostephd/wesnoth that referenced this issue Oct 18, 2018

Themes: Fix the observers icon being hidden under the minimap
Closes wesnoth#3543. Fixups wesnoth#3441.

The observers icon is declared immediately after `report_timeout`,
therefore the timeout widget was the ref rect for the observers widget:
https://github.com/wesnoth/wesnoth/blob/83ba09a5a98b817a3e50a89dd6b41d2f779af5ff/src/theme.cpp#L120

PR wesnoth#3441 added a battery icon to the left of the timeout widget. That
shifted the timeout widget to the right and the observers widget shifted
along with it due to its relative positioning. The observers widget
moved even on devices that didn't have a battery.

Fix this by using the battery box as the ref of the observers widget,
because it currently occupies the absolute location the observers widget
was positioned relatively to.

(cherry picked from commit 461cd2c)

jostephd added a commit to jostephd/wesnoth that referenced this issue Oct 27, 2018

Themes: Fix the observers icon being hidden under the minimap
Closes wesnoth#3543. Fixups wesnoth#3441.

The observers icon is declared immediately after `report_timeout`,
therefore the timeout widget was the ref rect for the observers widget:
https://github.com/wesnoth/wesnoth/blob/83ba09a5a98b817a3e50a89dd6b41d2f779af5ff/src/theme.cpp#L120

PR wesnoth#3441 added a battery icon to the left of the timeout widget. That
shifted the timeout widget to the right and the observers widget shifted
along with it due to its relative positioning. The observers widget
moved even on devices that didn't have a battery.

Fix this by using the battery box as the ref of the observers widget,
because it currently occupies the absolute location the observers widget
was positioned relatively to.

(cherry picked from commit 461cd2c)

jostephd added a commit to jostephd/wesnoth that referenced this issue Oct 27, 2018

Themes: Fix the observers icon being hidden under the minimap
Closes wesnoth#3543. Fixups wesnoth#3441.

The observers icon is declared immediately after `report_timeout`,
therefore the timeout widget was the ref rect for the observers widget:
https://github.com/wesnoth/wesnoth/blob/83ba09a5a98b817a3e50a89dd6b41d2f779af5ff/src/theme.cpp#L120

PR wesnoth#3441 added a battery icon to the left of the timeout widget. That
shifted the timeout widget to the right and the observers widget shifted
along with it due to its relative positioning. The observers widget
moved even on devices that didn't have a battery.

Fix this by using the battery box as the ref of the observers widget,
because it currently occupies the absolute location the observers widget
was positioned relatively to.

(cherry picked from commit 461cd2c)

jostephd added a commit to jostephd/wesnoth that referenced this issue Oct 28, 2018

Themes: Fix the observers icon being hidden under the minimap
Closes wesnoth#3543. Fixups wesnoth#3441.

The observers icon is declared immediately after `report_timeout`,
therefore the timeout widget was the ref rect for the observers widget:
https://github.com/wesnoth/wesnoth/blob/83ba09a5a98b817a3e50a89dd6b41d2f779af5ff/src/theme.cpp#L120

PR wesnoth#3441 added a battery icon to the left of the timeout widget. That
shifted the timeout widget to the right and the observers widget shifted
along with it due to its relative positioning. The observers widget
moved even on devices that didn't have a battery.

Fix this by using the battery box as the ref of the observers widget,
because it currently occupies the absolute location the observers widget
was positioned relatively to.

(cherry picked from commit 461cd2c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.