Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plan Unit Advancement UI is not consistent with the rest of game UI #5555

Closed
grz0 opened this issue Feb 16, 2021 · 2 comments
Closed

Plan Unit Advancement UI is not consistent with the rest of game UI #5555

grz0 opened this issue Feb 16, 2021 · 2 comments
Assignees
@irydacea
Labels
Bug Issues involving unexpected behavior. MP Issues with multiplayer support or bundled multiplayer content. UI User interface issues, including both back-end and front-end issues.

Comments

@grz0
Copy link
Contributor

grz0 commented Feb 16, 2021

Game and System Information

The Battle for Wesnoth version 1.15.9+dev (a0ee38a-Clean) x86_64

Describe the bug

Plan Unit Advancement UI is not consistent with the rest of the game UI:

  • the window's title has a different font style than other dialogues
  • unit color doesn't match team color, it is always pink
  • cancel button is missing
  • IMHO 'Save(All)' button should be replaced with a checkbox

Current implementation:
image

vs my quick attempt to fix these issues:
image
@CelticMinstrel
Copy link
Member

Or maybe a radiobutton?

(*) Apply only to <unit name>
( ) Apply to all <unit type>s

irydacea added a commit that referenced this issue Feb 17, 2021
@irydacea
pick_advance: Bring the UI layout more in line with the game engine
bb6ef63 
This does alter some of the code significantly to make it less "clever"
(no more dynamic build) but also less hostile to future modifications
like this.

(CC #5555)
irydacea added a commit that referenced this issue Feb 17, 2021
@irydacea
pick_advance: Use the correct team colour settings
a426d9f 
Also removed a listbox selection callback that serves no purpose beyond
re-setting the selection's icon to what it already is. Weird code.

(CC #5555)
irydacea added a commit that referenced this issue Feb 17, 2021
@irydacea
pick_advance: Add Cancel button
1530ab8 
(CC #5555)
@irydacea irydacea self-assigned this Feb 17, 2021
@irydacea irydacea added Bug Issues involving unexpected behavior. MP Issues with multiplayer support or bundled multiplayer content. UI User interface issues, including both back-end and front-end issues. labels Feb 17, 2021
@irydacea
Copy link
Member

All should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@irydacea irydacea

Labels
Bug Issues involving unexpected behavior. MP Issues with multiplayer support or bundled multiplayer content. UI User interface issues, including both back-end and front-end issues.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@irydacea @CelticMinstrel @grz0