Add a composite hero/leader ellipse

[cooljeanius]

If an add-on author tries to use {IS_HERO} or the ellipse misc/ellipse-hero for a unit with canrecruit=yes, they end up getting messages like error display: could not open image 'misc/ellipse-hero-leader-top.png'. (I have had this happen to me before myself.) Technically this is Wesnoth just doing what it's told, so there's no need to change any code here, but it would be useful to at least add a composite ellipse with that path for this particular case, at least IMO.

[knyghtmare]

If an add-on author tries to use {IS_HERO} or the ellipse misc/ellipse-hero for a unit with canrecruit=yes, they end up getting messages like error display: could not open image 'misc/ellipse-hero-leader-top.png'. (I have had this happen to me before myself.) Technically this is Wesnoth just doing what it's told, so there's no need to change any code here, but it would be useful to at least add a composite ellipse with that path for this particular case, at least IMO.

I have had this issue the most in my campaign for the first arc. Previously, in 1.10/1.12 series, it was possible to have both, with the hero icon being overlayed on top of the leader icon.

[cooljeanius]

I have had this issue the most in my campaign for the first arc. Previously, in 1.10/1.12 series, it was possible to have both, with the hero icon being overlayed on top of the leader icon.

Hm, do you think you could bisect to find which commit changed this?

[doofus-01]

I have had this issue the most in my campaign for the first arc. Previously, in 1.10/1.12 series, it was possible to have both, with the hero icon being overlayed on top of the leader icon.

I believe this is for the ellipse (side-colored things on the ground), not icons (the little floating gold/silver trinkets).

Maybe a hack, but simply copying the leader ellipse images and calling them "ellipse-hero-leader" should work. Any reason not to do that?

[cooljeanius]

I have had this issue the most in my campaign for the first arc. Previously, in 1.10/1.12 series, it was possible to have both, with the hero icon being overlayed on top of the leader icon.

I believe this is for the ellipse (side-colored things on the ground), not icons (the little floating gold/silver trinkets).

Maybe a hack, but simply copying the leader ellipse images and calling them "ellipse-hero-leader" should work. Any reason not to do that?

Let's ask @irydacea

[cooljeanius]

I have had this issue the most in my campaign for the first arc. Previously, in 1.10/1.12 series, it was possible to have both, with the hero icon being overlayed on top of the leader icon.

I believe this is for the ellipse (side-colored things on the ground), not icons (the little floating gold/silver trinkets).
Maybe a hack, but simply copying the leader ellipse images and calling them "ellipse-hero-leader" should work. Any reason not to do that?

Let's ask @irydacea

(it works perfectly fine when doing so as part of an add-on, btw)

[CelticMinstrel]

I also think it would be perfectly acceptable to just duplicate the regular leader ellipse for this, as @doofus-01 suggested.