-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loyal icon superimposed and prestart messages fixes #447
Conversation
Feel free to continue, I will merge it then. I never paid much attention to these icons and I didn't notice it didn't always work as it should have. |
Extra check to avoid give loyal icon to a leader, who already has a crown. |
I'll continue here the same cases as here #456 that I find myself throughout the campaign because sometimes the same files are changed, to avoid conflicts. |
See the last commit "Fixed loyal random gift..." |
9cd8213
to
e55eaf7
Compare
It's not a secret objective, they mention it explicitly at the beginning
30af8ad
to
469cf4e
Compare
@Dugy see the last commit. The shop only allows you to buy 1 item and you have to move the unit to one adjacent square to buy again. As the solution was simple, enclosing the message in a while until "Nothing" is clicked, I have done it for all shops. What do you think, do I keep those changes, or is the original intention for the shops to be for 1 use only? |
Yeah, keep that. I thought about giving it a nicer GUI, but I didn't get myself to do it. |
@Dugy on the last commit I have fixed a problem that makes Vlad attack in the opposite direction of the victim and it looks bad. I guess that you are okay with this, it's a little fix. |
For example, Stormrider on Invasion and Bloodbath. They will no longer show the error image in yellow with debug mode and this error on logs: 20230601 16:27:01 error image: could not open image 'misc/ellipse-hero-leader-selected-top.png' 20230601 16:27:01 error image: could not open image 'misc/ellipse-hero-leader-selected-bottom.png'
@Dugy read description on the last commit. |
I don't have the rights to view anything in that Discord channel. |
Yeah, I am fine with that addition. |
I have finished the entire part 1, it is ready for review, all the changes have been checked throughout these months. |
Looks okay. You've done two unrelated things in a large number of commits in a single pull request. I am not asking you to split it up because it would be really annoying work, but next time please make two pull requests for things like this. I've merged it all now. |
These icon overlays are a problem caused either by the loyal code without an empty overlay, or by using IS_HERO and TRAIT_LOYAL together, existing TRAIT_LOYAL_HERO, better and more specific. And also because of the lua code that adds the loyal icon to all loyal units without checking if they are also heroes. The easiest way to spot it is to check if it has the hero ellipse effect.
Once the first two scenarios are resolved for Delenia and Mario , if the changes seem good to you, I will do it with other characters with the same problem as I progress in the campaign, since I like that the icons on characters that will accompany me in many chapters look beautiful.