Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Campaign] [SP] Clean Up THoT's code #6587

Closed
2 tasks
knyghtmare opened this issue Mar 27, 2022 · 1 comment · Fixed by #6593
Closed
2 tasks

[Campaign] [SP] Clean Up THoT's code #6587

knyghtmare opened this issue Mar 27, 2022 · 1 comment · Fixed by #6593
Labels
Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign Enhancement Issues that are requests for new features or changes to existing ones. Units Issues that involve unit definitions or their implementation in the engine.

Comments

@knyghtmare
Copy link
Member

While foraging code from this campaign and NR for the...well, you know, I have stumbled on things which seem to be obsolete code bits and files no longer in use.
Thus, I am listing them here for removal (or moving them to attic).

  • Character Stat Rathlyn
  • Rathlyn's portrait

Backstory:
This character was a loyal Arch Mage given in High Pass scenario before the campaign was reworked. After the rework, he is no longer present in this campaign but his character stats define and portrait have stayed. They are no longer required.

@Wedge009 Wedge009 added Enhancement Issues that are requests for new features or changes to existing ones. Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign Units Issues that involve unit definitions or their implementation in the engine. labels Mar 27, 2022
@Wedge009
Copy link
Member

I had trouble finding what you were referring to because it looks like the character in question is actually Ratheln, not Rathlyn.

He is still marked for recall in scenarios 9 and 10 - is it the case that if the unit doesn't exist in the recall list, then the recall fails silently (or at least without obvious error)?

Wedge009 added a commit to Wedge009/wesnoth that referenced this issue Mar 27, 2022
Wedge009 added a commit to Wedge009/wesnoth that referenced this issue Mar 27, 2022
Wedge009 added a commit that referenced this issue Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign Enhancement Issues that are requests for new features or changes to existing ones. Units Issues that involve unit definitions or their implementation in the engine.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants