Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THoT: Remove unused Ratheln character #6593

Merged
merged 1 commit into from Mar 28, 2022
Merged

Conversation

Wedge009
Copy link
Member

Resolves #6587

@Wedge009 Wedge009 added the Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign label Mar 27, 2022
@Wedge009 Wedge009 requested a review from nemaara March 27, 2022 22:13
@github-actions github-actions bot added the Graphics Issues that involve the graphics engine or assets. label Mar 27, 2022
Copy link
Member

@knyghtmare knyghtmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's all good. Also, might be good to move the rathelyn portrait to the https://github.com/wesnoth/resources repo

@Wedge009
Copy link
Member Author

What's the difference between that repository and 'attic'?

@doofus-01
Copy link
Member

I think the full-size image or layered image would go in resources, while retired "use-as-is" assets that someone might still want for some reason, like the down-scaled portrait, could go to the attic. At least, that has been my assumption, it would be good to get that confirmed or refuted.

@Wedge009
Copy link
Member Author

Yeah, I was leaning towards that too, just looking at the description of the repository vs the contents of 'attic'. I was trying to find where - if anywhere else - the image might have been used in Wesnoth but it doesn't look like it's used. I'll update to move instead of delete the image.

@nemaara
Copy link
Contributor

nemaara commented Mar 28, 2022

Is it worth keeping his portrait around? The quality is quite a bit lower than current mainline standards.

@Wedge009
Copy link
Member Author

I thought it still holds up in the current set of images, but if it's really deemed 'no good' any more, we can delete it later.

@Wedge009 Wedge009 merged commit 1726c1c into wesnoth:master Mar 28, 2022
@Wedge009 Wedge009 deleted the thot_ratheln branch March 28, 2022 04:07
@CelticMinstrel
Copy link
Member

Should mention of this image be added to the attic readme?

@Wedge009
Copy link
Member Author

Didn't notice that. Done in 79c3bfc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign Graphics Issues that involve the graphics engine or assets.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Campaign] [SP] Clean Up THoT's code
5 participants