Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Units] Give Elemental units their own race (race=elemental) #8890

Open
knyghtmare opened this issue May 21, 2024 · 10 comments
Open

[Units] Give Elemental units their own race (race=elemental) #8890

knyghtmare opened this issue May 21, 2024 · 10 comments
Labels
Enhancement Issues that are requests for new features or changes to existing ones. Units Issues that involve unit definitions or their implementation in the engine.

Comments

@knyghtmare
Copy link
Member

Describe the desired feature

We currently have the following units with the "elemental" trait. More might be added which use this trait as well.

  • Fire Wisp
  • Fire Guardian
  • Fire Wraith
  • Jinn
  • Mudcrawler
  • Giant Mudcrawler

I think it would be good to move them to their own race=elemental instead of being in the uncategorized 'race=monster'

Before you start with your "No...", I will remind you that moving units to their race= from monsters was done before: (The wolf units: 3, which is just half of the number of elemental trait units listed here).

Now, discuss!

@knyghtmare knyghtmare added Enhancement Issues that are requests for new features or changes to existing ones. Units Issues that involve unit definitions or their implementation in the engine. labels May 21, 2024
@knyghtmare
Copy link
Member Author

  • TODO: Impact Analysis Report on this Change in UMC (will do next week)

@Earth-Cake
Copy link
Contributor

Earth-Cake commented May 21, 2024

I could get behind this one, the monsters race seems too crowded as-is.

In my opinion, this raises another question: should there be a race = animals that would include units like Dragonfly Naiad, Dragonfly, Grand Dragonfly; Ant advancement tree, all types of Scorpions, Nibbler, Caribe, Pigglet, Woodland Boar, and perhaps Falcons?

@knyghtmare
Copy link
Member Author

I could get behind this one, the monsters race seems too crowded as-is.

In my opinion, this raises another question: should there be a race = animals that would include units like Dragonfly Naiad, Dragonfly, Grand Dragonfly; Ant advancement tree, all types of Scorpions, Nibbler, Caribe, Pigglet, Woodland Boar, and perhaps Falcons?

I rather not expand the scope so hurriedly. There are impact analysis reports to do and consider before doing each case.

@spixi
Copy link
Contributor

spixi commented May 21, 2024

race=monster can appear in many SUFs, so I would be very careful. You could even go further and have

race=arthropod for spiders, scorpions, ants, dragonflies, scarab
race=mammal for giant rat, cave bear, icemonaces, boars and yetis
etc.

@CelticMinstrel
Copy link
Member

race=monster can appear in many SUFs

Solution: define a race hierarchy so that when you write race=monster it also matches race=animal.

@spixi
Copy link
Contributor

spixi commented May 21, 2024

race=monster can appear in many SUFs

Solution: define a race hierarchy so that when you write race=monster it also matches race=animal.

Isn’t that paradox? A yeti is a monster, but is a yeti also considered to be an animal? A piglet is an animal, but is it also a monster?

@Earth-Cake
Copy link
Contributor

race=monster can appear in many SUFs, so I would be very careful. You could even go further and have

race=arthropod for spiders, scorpions, ants, dragonflies, scarab race=mammal for giant rat, cave bear, icemonaces, boars and yetis etc.

Alternatively, all Monsters could be separated in Help and sorted into different subfolders just like the Dunefolk are.

@CelticMinstrel
Copy link
Member

Isn’t that paradox? A yeti is a monster, but is a yeti also considered to be an animal? A piglet is an animal, but is it also a monster?

Well, I wouldn't call it a paradox, but you'd definitely find weird edge cases that don't quite fit. Certainly it might seem like a stretch to call a piglet a monster. Then again, calling a wild boar a monster isn't so strange, so if the adult form is a monster, naturally the juvenile form would be a monster too.

I would consider a yeti to be an animal as well – it's some sort of giant ape or something, like a gorilla but adapted for the peaks.

spixi added a commit to spixi/wesnoth that referenced this issue May 28, 2024
spixi added a commit to spixi/wesnoth that referenced this issue May 28, 2024
spixi added a commit to spixi/wesnoth that referenced this issue May 28, 2024
spixi added a commit to spixi/wesnoth that referenced this issue May 28, 2024
spixi added a commit to spixi/wesnoth that referenced this issue May 28, 2024
spixi added a commit to spixi/wesnoth that referenced this issue May 28, 2024
@Elvish-Hunter
Copy link
Contributor

  • TODO: Impact Analysis Report on this Change in UMC (will do next week)

What would this impact analysis involve exactly? Do you need me to grep the add-ons servers for some specific string/regex?

@knyghtmare
Copy link
Member Author

What would this impact analysis involve exactly? Do you need me to grep the add-ons servers for some specific string/regex?

Specifically, the report will be list of addons and the potential impact of this change on them.
For example, in War of Legends, there exists race=elemental so the change here would be the era's description of the race will be replaced by the mainline race description. Nothing major.

Another example, in Invasion from the Unknown (yet to be ported to 1.18, Come on, Iris, we're waiting): There is a boss unit called "Mother Mudcrawler". So, this unit would have to have a race change: monster -> elemental

and so on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Issues that are requests for new features or changes to existing ones. Units Issues that involve unit definitions or their implementation in the engine.
Projects
None yet
Development

No branches or pull requests

5 participants