-
-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Units] Give Elemental units their own race (race=elemental
)
#8890
Comments
|
I could get behind this one, the monsters race seems too crowded as-is. In my opinion, this raises another question: should there be a |
I rather not expand the scope so hurriedly. There are impact analysis reports to do and consider before doing each case. |
race=monster can appear in many SUFs, so I would be very careful. You could even go further and have race=arthropod for spiders, scorpions, ants, dragonflies, scarab |
Solution: define a race hierarchy so that when you write |
Isn’t that paradox? A yeti is a monster, but is a yeti also considered to be an animal? A piglet is an animal, but is it also a monster? |
Alternatively, all Monsters could be separated in Help and sorted into different subfolders just like the Dunefolk are. |
Well, I wouldn't call it a paradox, but you'd definitely find weird edge cases that don't quite fit. Certainly it might seem like a stretch to call a piglet a monster. Then again, calling a wild boar a monster isn't so strange, so if the adult form is a monster, naturally the juvenile form would be a monster too. I would consider a yeti to be an animal as well – it's some sort of giant ape or something, like a gorilla but adapted for the peaks. |
What would this impact analysis involve exactly? Do you need me to grep the add-ons servers for some specific string/regex? |
Specifically, the report will be list of addons and the potential impact of this change on them. Another example, in and so on. |
Describe the desired feature
We currently have the following units with the "elemental" trait. More might be added which use this trait as well.
I think it would be good to move them to their own
race=elemental
instead of being in the uncategorized 'race=monster'Before you start with your "No...", I will remind you that moving units to their
race=
from monsters was done before: (The wolf units: 3, which is just half of the number of elemental trait units listed here).Now, discuss!
The text was updated successfully, but these errors were encountered: