Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL hitboxes on centered text are left-aligned #8915

Open
stevecotton opened this issue May 25, 2024 · 1 comment
Open

URL hitboxes on centered text are left-aligned #8915

stevecotton opened this issue May 25, 2024 · 1 comment
Labels
Bug Issues involving unexpected behavior. Confirmed Issues that have been successfully reproduced by at least one developer. UI User interface issues, including both back-end and front-end issues.

Comments

@stevecotton
Copy link
Contributor

Game and System Information

  • Version: 1.18.0+dev (f4a1d25), 1.19+dev
  • OS: Linux (Debian testing distro, X11 session started 11 days ago)
  • libc6 2.38-11
  • libcairo2 1.18.0-3+b1
  • libfontconfig1 2.15.0-1.1
  • libgcc-s1 14-20240330-1
  • libglib2.0-0t64 2.80.2-1
  • libpango-1.0-0 1.52.2+ds-1
  • libpangocairo-1.0-0 1.52.2+ds-1
  • libsdl2-2.0-0 2.30.2+dfsg-1
  • libsdl2-image-2.0-0 2.8.2+dfsg-1+b1
  • libsdl2-mixer-2.0-0 2.8.0+dfsg-1+b2

Description of the bug

The red areas are (approximately) where the cursor changes and clicking opens a confirmation dialog to open the link. The non-red areas are just text, and clicking there does nothing. Screenshot is from a 1.19+dev build with work in progress on PR #8905, but the same issue is reproducible on the current 1.18 branch at commit f4a1d25.

image

The areas are approximate (drew on top of a screenshot rather than having a way to see the exact area), and on 1.18 the right edges of the hitbox are slightly further left. On 1.18 the left edges seem to be in the same x coordinate for both texts, however on 1.19 the left edge of the area is, as shown in the screenshot, a few pixels further right for the longer piece of text.

Steps to reproduce the behavior

  1. From the title screen, open the language selection
  2. Hover over the links

Expected behavior

No response

Additional context

The UI that shows this bug is a new feature that's added to 1.18.1 but wasn't in 1.18.0.

@stevecotton stevecotton added Bug Issues involving unexpected behavior. UI User interface issues, including both back-end and front-end issues. labels May 25, 2024
@Wedge009 Wedge009 added the Confirmed Issues that have been successfully reproduced by at least one developer. label May 26, 2024
@Wedge009
Copy link
Member

Something is odd about the way this is implemented - the active link areas seem to match what's reported but if I switch to pixel scaling of 2, the active link areas expand considerably. Presumably it would expand again at scaling of 3 and higher.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues involving unexpected behavior. Confirmed Issues that have been successfully reproduced by at least one developer. UI User interface issues, including both back-end and front-end issues.
Projects
None yet
Development

No branches or pull requests

2 participants